-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] add all the get factory info interface #24406
Merged
bzbarsky-apple
merged 6 commits into
project-chip:master
from
Jerry-ESP:ESP32/add_all_factory_api
Feb 15, 2023
Merged
[ESP32] add all the get factory info interface #24406
bzbarsky-apple
merged 6 commits into
project-chip:master
from
Jerry-ESP:ESP32/add_all_factory_api
Feb 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google and
mrjerryjohns
January 13, 2023 09:34
PR #24406: Size comparison from 2a55f23 to 9823cdd Increases (8 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (6 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 13, 2023
shubhamdp
reviewed
Jan 13, 2023
shubhamdp
reviewed
Jan 13, 2023
chshu
force-pushed
the
ESP32/add_all_factory_api
branch
from
February 6, 2023 08:48
9823cdd
to
2c8927a
Compare
PR #24406: Size comparison from 655d134 to 2c8927a Increases (10 builds for bl602, efr32, esp32, psoc6, telink)
Decreases (2 builds for esp32, qpg)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24406: Size comparison from a894041 to cf41c7e Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Jerry-ESP
force-pushed
the
ESP32/add_all_factory_api
branch
from
February 8, 2023 06:30
cf41c7e
to
99d82cc
Compare
shubhamdp
approved these changes
Feb 8, 2023
PR #24406: Size comparison from e32359f to 99d82cc Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #24406: Size comparison from c7b1748 to e241cd8 Full report (4 builds for cc32xx, mbed, qpg)
|
PR #24406: Size comparison from 738d33c to bf7b0ce Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #24406: Size comparison from 6ce0f90 to e9eec10 Full report (1 build for cc32xx)
|
chshu
approved these changes
Feb 14, 2023
PR #24406: Size comparison from a6d2883 to 08b520a Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ESP32 platform, some get factory info functions not define in one files, it is inconvenient for some customers.
So I add all the apis in ESP32FactoryDataProvider.cpp file to easy to use.
The api include:
GetSerialNumber(char * buf, size_t bufSize) ;
GetManufacturingDate(uint16_t & year, uint8_t & month, uint8_t & day) ;
GetPartNumber(char * buf, size_t bufSize);
GetHardwareVersion(uint16_t & hardwareVersion);