[ESP32] Make all parameters optional in partition generator script #24362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #24362: Size comparison from 18d3671 to a936cf0 Increases (5 builds for cc13x2_26x2, efr32, esp32, telink)
Decreases (5 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jan 11, 2023
andy31415
reviewed
Jan 11, 2023
andy31415
reviewed
Jan 11, 2023
|
PR #24362: Size comparison from 18d3671 to 795068a Increases above 0.2%:
Increases (4 builds for efr32, esp32, qpg, telink)
Decreases (10 builds for bl602, bl702, k32w, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 12, 2023
andy31415
reviewed
Jan 16, 2023
andy31415
reviewed
Jan 16, 2023
andy31415
reviewed
Jan 16, 2023
andy31415
approved these changes
Jan 16, 2023
|
Thanks for the review @andy31415 |
Initially script was a bit rigid and few parameters were mandatory and its a bit cumbersome to test if you just need to test with different discriminator. Added an option --no-bin which will only generate the nvs partition csv file and not the nvs partition binary. This is helpful when matter specific data is needed and not the actual binary.
- Removed all usage of `is not None` its not a pythonic way - Removed `required=False` as default is already False
shubhamdp
force-pushed
the
esp32_script_fixes
branch
from
4f8155b to
39f5b6c
Compare
|
PR #24362: Size comparison from 57de760 to 39f5b6c Increases (6 builds for bl702, esp32, psoc6, qpg, telink)
Decreases (4 builds for bl602, esp32, nrfconnect, psoc6)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…roject-chip#24362) * [ESP32] Make all parameters optional in partition generator script Initially script was a bit rigid and few parameters were mandatory and its a bit cumbersome to test if you just need to test with different discriminator. Added an option --no-bin which will only generate the nvs partition csv file and not the nvs partition binary. This is helpful when matter specific data is needed and not the actual binary. * Address review comments - Removed all usage of `is not None` its not a pythonic way - Removed `required=False` as default is already False * fix few ifs against the number input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially script was a bit rigid and few parameters were mandatory and its a bit cumbersome to test if you just need to test with different discriminator and passcode.
Also, added an option
--no-binwhich will only generate the nvs partition csv file and not the nvs partition binary. This is helpful when matter specific data is needed and not the actual binary.