-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the ClientMonitoring cluster APIs on Darwin for now. #24348
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:disable-client-monitoring-darwin
Jan 11, 2023
Merged
Disable the ClientMonitoring cluster APIs on Darwin for now. #24348
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:disable-client-monitoring-darwin
Jan 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not quite stable enough to ship as public API yet. Adds wasRemoved checks to various places so we handle removals better in our codegen.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
January 10, 2023 17:50
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 10, 2023 17:50
PR #24348: Size comparison from faa7b08 to e373c74 Increases (4 builds for cyw30739, esp32, nrfconnect, qpg)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Jan 10, 2023
Fast-tracking platform-specific change with platform owner review. |
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…-chip#24348) It's not quite stable enough to ship as public API yet. Adds wasRemoved checks to various places so we handle removals better in our codegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not quite stable enough to ship as public API yet.
Adds wasRemoved checks to various places so we handle removals better in our codegen.