-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Mode Select cluster XML with the spec. #24345
Merged
andy31415
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-mode-select
Jan 10, 2023
Merged
Align naming in Mode Select cluster XML with the spec. #24345
andy31415
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-mode-select
Jan 10, 2023
+120
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app
controller
darwin
examples
github
integrations
scripts
workflows
labels
Jan 10, 2023
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple and
lazarkov
January 10, 2023 15:21
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple and
xylophone21
January 10, 2023 15:21
bzbarsky-apple
force-pushed
the
rename-mode-select
branch
from
January 10, 2023 15:26
f519ccd
to
2769935
Compare
andy31415
approved these changes
Jan 10, 2023
PR #24345: Size comparison from 6a0fb2e to 2769935 Increases (3 builds for bl702, telink)
Decreases (9 builds for bl602, bl702, nrfconnect, qpg, telink)
Full report (29 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-mode-select
branch
from
January 10, 2023 16:39
2769935
to
9914dab
Compare
jmartinez-silabs
approved these changes
Jan 10, 2023
andy31415
reviewed
Jan 10, 2023
src/app/zap-templates/zcl/data-model/chip/mode-select-cluster.xml
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jan 10, 2023
src/app/zap-templates/zcl/data-model/chip/mode-select-cluster.xml
Outdated
Show resolved
Hide resolved
PR #24345: Size comparison from f15228d to 9914dab Increases (10 builds for bl602, bl702, psoc6, telink)
Decreases (8 builds for bl702, esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-mode-select
branch
from
January 10, 2023 18:11
9914dab
to
32871f6
Compare
PR #24345: Size comparison from faa7b08 to 32871f6 Increases (13 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, psoc6, telink)
Decreases (8 builds for bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…24345) * Align naming in Mode Select cluster XML with the spec. * Regenerate generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.