Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of quick fixes to yamltests parser #24331

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Couple of quick fixes to yamltests parser #24331

merged 1 commit into from
Jan 9, 2023

Conversation

tehampson
Copy link
Contributor

These fixes are needed for multi admin support. They were missed when doing some refactoring in the yamltests parser.

Test: With local changes to TestClusterMultiFabric.yaml using chip-repl confirmed that the changes allow the test to function properly

@tehampson
Couple of quick fixes to yamltests parser
3896c74 
These fixes are needed for multi admin support. They were missed when
doing some refactoring in the yamltests parser.
@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited
Loading

PR #24331: Size comparison from ffc8d97 to 3896c74

Increases (8 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, telink)
platform target config section ffc8d97 3896c74 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 642435 642443 8 0.0
.text 562976 562984 8 0.0
lock-ftd LP_CC2652R7 (read only) 675559 675567 8 0.0
.text 597664 597672 8 0.0
pump-controller-app LP_CC2652R7 (read only) 672659 672667 8 0.0
.text 585592 585600 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550558 550566 8 0.0
.app_xip_area 432392 432400 8 0.0
esp32 all-clusters-app c3devkit (read only) 1219574 1219576 2 0.0
(read/write) 1791034 1791050 16 0.0
.flash.rodata 248472 248488 16 0.0
.flash.text 1219574 1219576 2 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 801930 801934 4 0.0
telink light-switch-app tlsr9518adk80d (read/write) 931032 931040 8 0.0
text 637382 637386 4 0.0
ota-requestor-app tlsr9518adk80d text 648630 648632 2 0.0
Decreases (9 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
platform target config section ffc8d97 3896c74 change % change
bl602 lighting-app bl602+rpc .text 1047380 1047378 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 44200699 44200697 -2 -0.0
.text 1033766 1033762 -4 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 173448 173440 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 177188 177180 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 564267 564263 -4 -0.0
.flash.rodata 314260 314256 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27081519 27081518 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22280234 22280233 -1 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1070344 1070336 -8 -0.0
text 725626 725622 -4 -0.0
contact-sensor-app tlsr9518adk80d text 622846 622844 -2 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section ffc8d97 3896c74 change % change
bl602 lighting-app bl602 (read/write) 1330486 1330486 0 0.0
.bss 86926 86926 0 0.0
.data 9576 9576 0 0.0
.text 1016646 1016646 0 0.0
bl602+rpc (read/write) 1375734 1375734 0 0.0
.bss 94966 94966 0 0.0
.data 9976 9976 0 0.0
.text 1047380 1047378 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195823 1195823 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1534627 1534627 0 0.0
.debug_aranges 132560 132560 0 0.0
.debug_frame 486668 486668 0 0.0
.debug_info 39815516 39815516 0 0.0
.debug_line 5219520 5219520 0 0.0
.debug_loc 3393185 3393185 0 0.0
.debug_ranges 372040 372040 0 0.0
.debug_str 3505479 3505479 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 116400 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569315 569315 0 0.0
.symtab 172000 172000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956872 956872 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1287987 1287987 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1683073 1683073 0 0.0
.debug_aranges 140784 140784 0 0.0
.debug_frame 514380 514380 0 0.0
.debug_info 44200699 44200697 -2 -0.0
.debug_line 5616992 5616992 0 0.0
.debug_loc 3589149 3589149 0 0.0
.debug_ranges 395744 395744 0 0.0
.debug_str 3908089 3908089 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130864 130864 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629830 629830 0 0.0
.symtab 190320 190320 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033766 1033762 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678075 678075 0 0.0
(read/write) 173372 173372 0 0.0
.bss 81140 81140 0 0.0
.data 3380 3380 0 0.0
.rodata 89995 89995 0 0.0
.text 587768 587768 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642435 642443 8 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79139 79139 0 0.0
.text 562976 562984 8 0.0
lock-ftd LP_CC2652R7 (read only) 675559 675567 8 0.0
(read/write) 173448 173440 -8 -0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 77415 0 0.0
.text 597664 597672 8 0.0
lock-mtd LP_CC2652R7 (read only) 660611 660611 0 0.0
(read/write) 183660 183660 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 103507 0 0.0
.text 556624 556624 0 0.0
pump-app LP_CC2652R7 (read only) 688871 688871 0 0.0
(read/write) 160872 160872 0 0.0
.bss 78756 78756 0 0.0
.data 3268 3268 0 0.0
.rodata 91103 91103 0 0.0
.text 597284 597284 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672659 672667 8 0.0
(read/write) 177188 177180 -8 -0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86587 86587 0 0.0
.text 585592 585600 8 0.0
shell LP_CC2652R7 (read only) 669330 669330 0 0.0
(read/write) 184444 184444 0 0.0
.bss 83468 83468 0 0.0
.data 3376 3376 0 0.0
.rodata 86738 86738 0 0.0
.text 582276 582276 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586754 586754 0 0.0
.app_xip_area 463100 463100 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590454 590454 0 0.0
.app_xip_area 461504 461504 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550558 550566 8 0.0
.app_xip_area 432392 432400 8 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975172 975172 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 820812 820812 0 0.0
BRD4161A+rs911x (read/write) 1038320 1038320 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 849640 849640 0 0.0
BRD4187C (read/write) 1149004 1149004 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 983324 983324 0 0.0
lock-app BRD4161A+wf200 (read/write) 1067840 1067840 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 907612 907612 0 0.0
window-app BRD4187C (read/write) 1141808 1141808 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 974688 974688 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219574 1219576 2 0.0
(read/write) 1791034 1791050 16 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248472 248488 16 0.0
.flash.text 1219574 1219576 2 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233447 1233447 0 0.0
(read/write) 564267 564263 -4 -0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314260 314256 -4 -0.0
.flash.text 1228063 1228063 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 661196 661196 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 562948 562948 0 0.0
light k32w0+release (read/write) 672072 672072 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 592460 592460 0 0.0
lock k32w0+release (read/write) 632740 632740 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 552348 552348 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10667164 10667164 0 0.0
(read/write) 690504 690504 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 634856 634856 0 0.0
.dynamic 560 560 0 0.0
.got 13920 13920 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 550156 550156 0 0.0
.text 8481812 8481812 0 0.0
thermostat-no-ble arm64 (read only) 2478452 2478452 0 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149712 149712 0 0.0
.text 2068144 2068144 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2462912 2462912 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1425556 1425556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1161587 1161587 0 0.0
bss 143621 143621 0 0.0
rodata 136176 136176 0 0.0
text 801930 801934 4 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1341494 1341494 0 0.0
bss 105132 105132 0 0.0
rodata 204040 204040 0 0.0
text 747796 747796 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1108091 1108091 0 0.0
bss 142856 142856 0 0.0
rodata 112504 112504 0 0.0
text 772932 772932 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842056 842056 0 0.0
(read/write) 1749268 1749268 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1243463 1243463 0 0.0
.debug_aranges 110840 110840 0 0.0
.debug_frame 372300 372300 0 0.0
.debug_info 27081519 27081518 -1 -0.0
.debug_line 3735193 3735193 0 0.0
.debug_loc 3637422 3637422 0 0.0
.debug_ranges 355584 355584 0 0.0
.debug_str 3459152 3459152 0 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 572577 572577 0 0.0
.symtab 422416 422416 0 0.0
.text 0 0 0 0.0
1549592 1549592 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1691908 1691908 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235244 1235244 0 0.0
.debug_aranges 110312 110312 0 0.0
.debug_frame 375356 375356 0 0.0
.debug_info 26817884 26817884 0 0.0
.debug_line 3754091 3754091 0 0.0
.debug_loc 3625028 3625028 0 0.0
.debug_ranges 354200 354200 0 0.0
.debug_str 3448164 3448164 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536666 536666 0 0.0
.symtab 408688 408688 0 0.0
.text 1492960 1492960 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1609916 1609916 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1068633 1068633 0 0.0
.debug_aranges 102512 102512 0 0.0
.debug_frame 345688 345688 0 0.0
.debug_info 22280234 22280233 -1 -0.0
.debug_line 3320126 3320126 0 0.0
.debug_loc 3325256 3325256 0 0.0
.debug_ranges 318336 318336 0 0.0
.debug_str 3253750 3253750 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472991 472991 0 0.0
.symtab 377184 377184 0 0.0
.text 1419160 1419160 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1643932 1643932 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1070433 1070433 0 0.0
.debug_aranges 102896 102896 0 0.0
.debug_frame 347488 347488 0 0.0
.debug_info 22498898 22498898 0 0.0
.debug_line 3321289 3321289 0 0.0
.debug_loc 3346814 3346814 0 0.0
.debug_ranges 320192 320192 0 0.0
.debug_str 3269588 3269588 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475708 475708 0 0.0
.symtab 379008 379008 0 0.0
.text 1448184 1448184 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149452 1149452 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 596552 596552 0 0.0
lock-app qpg6105+debug (read/write) 1115884 1115884 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 562980 562980 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1070344 1070336 -8 -0.0
bss 98268 98268 0 0.0
text 725626 725622 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1009616 1009616 0 0.0
bss 97488 97488 0 0.0
text 690768 690768 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 914532 914532 0 0.0
bss 89644 89644 0 0.0
text 622846 622844 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 931032 931040 8 0.0
bss 89736 89736 0 0.0
text 637382 637386 4 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1009000 1009000 0 0.0
bss 97796 97796 0 0.0
text 703158 703158 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944624 944624 0 0.0
bss 90688 90688 0 0.0
text 648630 648632 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934192 934192 0 0.0
bss 91124 91124 0 0.0
text 638082 638082 0 0.0

@tehampson tehampson enabled auto-merge (squash) January 9, 2023 18:08
@tehampson tehampson merged commit b281d1b into project-chip:master Jan 9, 2023
cletnick pushed a commit to cletnick/connectedhomeip that referenced this pull request Jan 10, 2023
@tehampson @cletnick
Couple of quick fixes to yamltests parser (project-chip#24331)
7de4dc1 
These fixes are needed for multi admin support. They were missed when
doing some refactoring in the yamltests parser.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@tehampson
Couple of quick fixes to yamltests parser (project-chip#24331)
efdc6f4 
These fixes are needed for multi admin support. They were missed when
doing some refactoring in the yamltests parser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivien-apple vivien-apple vivien-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tehampson @andy31415 @vivien-apple