Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict the set of structs for which we generate legacy definitions. #24309

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Restrict the set of structs for which we generate legacy definitions. #24309

merged 2 commits into from
Jan 6, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Most of the things in af-structs.h are not used, and fixing the names of some of them causes bad name collisions due to lack of namespacing. Just stop generating all of them except the ones we really use.

@bzbarsky-apple
Restrict the set of structs for which we generate legacy definitions.
3436b65 
Most of the things in af-structs.h are not used, and fixing the names
of some of them causes bad name collisions due to lack of namespacing.
Just stop generating all of them except the ones we really use.
@github-actions
Copy link

github-actions bot commented Jan 6, 2023 •
edited
Loading

PR #24309: Size comparison from 98366cb to 0aeadcd

Increases (4 builds for bl702, cc13x2_26x2, psoc6, telink)
platform target config section 98366cb 0aeadcd change % change
bl702 lighting-app bl702+rpc .debug_info 44092236 44092237 1 0.0
.text 1033804 1033806 2 0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 660811 660819 8 0.0
.text 556824 556832 8 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_loc 3346799 3346814 15 0.0
telink all-clusters-app tlsr9518adk80d text 724812 724816 4 0.0
Decreases (8 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
platform target config section 98366cb 0aeadcd change % change
bl602 lighting-app bl602+rpc .text 1053116 1053114 -2 -0.0
bl702 lighting-app bl702 .debug_info 39725272 39725271 -1 -0.0
.text 957008 957006 -2 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 183460 183452 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 564267 564263 -4 -0.0
.flash.rodata 314260 314256 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27081527 27081520 -7 -0.0
.debug_loc 3637438 3637422 -16 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26817893 26817884 -9 -0.0
.debug_loc 3625044 3625028 -16 -0.0
lock cy8ckit_062s2_43012 .debug_info 22498926 22498898 -28 -0.0
telink lighting-app tlsr9518adk80d text 702348 702346 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 98366cb 0aeadcd change % change
bl602 lighting-app bl602 (read/write) 1344626 1344626 0 0.0
.bss 86510 86510 0 0.0
.data 9584 9584 0 0.0
.text 1022162 1022162 0 0.0
bl602+rpc (read/write) 1390074 1390074 0 0.0
.bss 94550 94550 0 0.0
.data 9976 9976 0 0.0
.text 1053116 1053114 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195951 1195951 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1534627 1534627 0 0.0
.debug_aranges 132552 132552 0 0.0
.debug_frame 486644 486644 0 0.0
.debug_info 39725272 39725271 -1 -0.0
.debug_line 5219470 5219470 0 0.0
.debug_loc 3392838 3392838 0 0.0
.debug_ranges 371904 371904 0 0.0
.debug_str 3503937 3503937 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 116400 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569365 569365 0 0.0
.symtab 172000 172000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957008 957006 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1288003 1288003 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1682752 1682752 0 0.0
.debug_aranges 140680 140680 0 0.0
.debug_frame 514176 514176 0 0.0
.debug_info 44092236 44092237 1 0.0
.debug_line 5616003 5616003 0 0.0
.debug_loc 3588130 3588130 0 0.0
.debug_ranges 395512 395512 0 0.0
.debug_str 3906472 3906472 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130848 130848 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629954 629954 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033804 1033806 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678283 678283 0 0.0
(read/write) 173164 173164 0 0.0
.bss 81140 81140 0 0.0
.data 3380 3380 0 0.0
.rodata 89995 89995 0 0.0
.text 587976 587976 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642643 642643 0 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79139 79139 0 0.0
.text 563184 563184 0 0.0
lock-ftd LP_CC2652R7 (read only) 675711 675711 0 0.0
(read/write) 173296 173296 0 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 77415 0 0.0
.text 597816 597816 0 0.0
lock-mtd LP_CC2652R7 (read only) 660811 660819 8 0.0
(read/write) 183460 183452 -8 -0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 103507 0 0.0
.text 556824 556832 8 0.0
pump-app LP_CC2652R7 (read only) 689015 689015 0 0.0
(read/write) 160728 160728 0 0.0
.bss 78756 78756 0 0.0
.data 3268 3268 0 0.0
.rodata 91103 91103 0 0.0
.text 597428 597428 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672811 0 0.0
(read/write) 177036 177036 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86587 86587 0 0.0
.text 585744 585744 0 0.0
shell LP_CC2652R7 (read only) 669530 669530 0 0.0
(read/write) 184244 184244 0 0.0
.bss 83468 83468 0 0.0
.data 3376 3376 0 0.0
.rodata 86738 86738 0 0.0
.text 582476 582476 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586850 586850 0 0.0
.app_xip_area 463196 463196 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590550 590550 0 0.0
.app_xip_area 461600 461600 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550710 550710 0 0.0
.app_xip_area 432544 432544 0 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975124 975124 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 820764 820764 0 0.0
BRD4161A+rs911x (read/write) 1038320 1038320 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 849640 849640 0 0.0
BRD4187C (read/write) 1149004 1149004 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 983324 983324 0 0.0
lock-app BRD4161A+wf200 (read/write) 1067840 1067840 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 907612 907612 0 0.0
window-app BRD4187C (read/write) 1141808 1141808 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 974688 974688 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219576 1219576 0 0.0
(read/write) 1791050 1791050 0 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248488 248488 0 0.0
.flash.text 1219576 1219576 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233447 1233447 0 0.0
(read/write) 564267 564263 -4 -0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314260 314256 -4 -0.0
.flash.text 1228063 1228063 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 661356 661356 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 563108 563108 0 0.0
light k32w0+release (read/write) 672216 672216 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 592604 592604 0 0.0
lock k32w0+release (read/write) 632884 632884 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 552492 552492 0 0.0
linux all-clusters-app debug (read only) 3113689 3113689 0 0.0
(read/write) 158568 158568 0 0.0
.bss 62432 62432 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87240 87240 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281835 281835 0 0.0
.text 2647170 2647170 0 0.0
all-clusters-minimal-app debug (read only) 2937113 2937113 0 0.0
(read/write) 149968 149968 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79608 79608 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 281195 281195 0 0.0
.text 2474274 2474274 0 0.0
bridge-app debug (read only) 2496537 2496537 0 0.0
(read/write) 133088 133088 0 0.0
.bss 52512 52512 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 70696 70696 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 212480 212480 0 0.0
.text 2112274 2112274 0 0.0
chip-tool debug (read only) 11171505 11171505 0 0.0
(read/write) 646880 646880 0 0.0
.bss 25880 25880 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 611648 611648 0 0.0
.dynamic 608 608 0 0.0
.got 5192 5192 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 606661 606661 0 0.0
.text 9065668 9065668 0 0.0
chip-tool-ipv6only arm64 (read only) 10583324 10583324 0 0.0
(read/write) 696104 696104 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 640528 640528 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 536124 536124 0 0.0
.text 8398740 8398740 0 0.0
lighting-app debug+rpc (read only) 2663713 2663713 0 0.0
(read/write) 132456 132456 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 74024 74024 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228448 228448 0 0.0
.text 2258514 2258514 0 0.0
lock-app debug (read only) 2622905 2622905 0 0.0
(read/write) 127440 127440 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70936 70936 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244680 244680 0 0.0
.text 2206322 2206322 0 0.0
ota-provider-app debug (read only) 2196793 2196793 0 0.0
(read/write) 105872 105872 0 0.0
.bss 46560 46560 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 52120 52120 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 196008 196008 0 0.0
.text 1860882 1860882 0 0.0
ota-requestor-app debug (read only) 2358249 2358249 0 0.0
(read/write) 113920 113920 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57208 57208 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202704 202704 0 0.0
.text 2006642 2006642 0 0.0
shell debug (read only) 2646337 2646337 0 0.0
(read/write) 143032 143032 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78136 78136 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 240050 240050 0 0.0
.text 2246578 2246578 0 0.0
thermostat-no-ble arm64 (read only) 2478452 2478452 0 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149712 149712 0 0.0
.text 2068144 2068144 0 0.0
tv-app debug (read only) 3285681 3285681 0 0.0
(read/write) 262280 262280 0 0.0
.bss 170776 170776 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80544 80544 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 269048 269048 0 0.0
.text 2822306 2822306 0 0.0
tv-casting-app debug (read only) 5627073 5627073 0 0.0
(read/write) 162640 162640 0 0.0
.bss 52152 52152 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101960 101960 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 361177 361177 0 0.0
.text 4988306 4988306 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2462848 2462848 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1425492 1425492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1161587 1161587 0 0.0
bss 143621 143621 0 0.0
rodata 136176 136176 0 0.0
text 801934 801934 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1341494 1341494 0 0.0
bss 105132 105132 0 0.0
rodata 204040 204040 0 0.0
text 747796 747796 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1108091 1108091 0 0.0
bss 142856 142856 0 0.0
rodata 112504 112504 0 0.0
text 772932 772932 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842056 842056 0 0.0
(read/write) 1749268 1749268 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1243463 1243463 0 0.0
.debug_aranges 110840 110840 0 0.0
.debug_frame 372300 372300 0 0.0
.debug_info 27081527 27081520 -7 -0.0
.debug_line 3735193 3735193 0 0.0
.debug_loc 3637438 3637422 -16 -0.0
.debug_ranges 355584 355584 0 0.0
.debug_str 3459524 3459524 0 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 572589 572589 0 0.0
.symtab 422416 422416 0 0.0
.text 0 0 0 0.0
1549592 1549592 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1691908 1691908 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235244 1235244 0 0.0
.debug_aranges 110312 110312 0 0.0
.debug_frame 375356 375356 0 0.0
.debug_info 26817893 26817884 -9 -0.0
.debug_line 3754091 3754091 0 0.0
.debug_loc 3625044 3625028 -16 -0.0
.debug_ranges 354200 354200 0 0.0
.debug_str 3448536 3448536 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536678 536678 0 0.0
.symtab 408688 408688 0 0.0
.text 1492960 1492960 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1609916 1609916 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1068633 1068633 0 0.0
.debug_aranges 102512 102512 0 0.0
.debug_frame 345688 345688 0 0.0
.debug_info 22280234 22280234 0 0.0
.debug_line 3320126 3320126 0 0.0
.debug_loc 3325256 3325256 0 0.0
.debug_ranges 318336 318336 0 0.0
.debug_str 3254122 3254122 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473003 473003 0 0.0
.symtab 377184 377184 0 0.0
.text 1419160 1419160 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1643932 1643932 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1070433 1070433 0 0.0
.debug_aranges 102896 102896 0 0.0
.debug_frame 347488 347488 0 0.0
.debug_info 22498926 22498898 -28 -0.0
.debug_line 3321289 3321289 0 0.0
.debug_loc 3346799 3346814 15 0.0
.debug_ranges 320192 320192 0 0.0
.debug_str 3269960 3269960 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475720 475720 0 0.0
.symtab 379008 379008 0 0.0
.text 1448184 1448184 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149556 1149556 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 596656 596656 0 0.0
lock-app qpg6105+debug (read/write) 1116044 1116044 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 563140 563140 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1068740 1068740 0 0.0
bss 97632 97632 0 0.0
text 724812 724816 4 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1008032 1008032 0 0.0
bss 96856 96856 0 0.0
text 689964 689964 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 929472 929472 0 0.0
bss 89104 89104 0 0.0
text 636566 636566 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1007440 1007440 0 0.0
bss 97156 97156 0 0.0
text 702348 702346 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 943068 943068 0 0.0
bss 90052 90052 0 0.0
text 647824 647824 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932644 932644 0 0.0
bss 90496 90496 0 0.0
text 637274 637274 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 8c7c641 into project-chip:master Jan 6, 2023
@bzbarsky-apple bzbarsky-apple deleted the legacy-struct-restrict branch January 6, 2023 23:59
cletnick pushed a commit to cletnick/connectedhomeip that referenced this pull request Jan 10, 2023
@bzbarsky-apple @cletnick
Restrict the set of structs for which we generate legacy definitions. (…
fca0bd3 
…project-chip#24309)

* Restrict the set of structs for which we generate legacy definitions.

Most of the things in af-structs.h are not used, and fixing the names
of some of them causes bad name collisions due to lack of namespacing.
Just stop generating all of them except the ones we really use.

* Address review comment
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Restrict the set of structs for which we generate legacy definitions. (…
31e8721 
…project-chip#24309)

* Restrict the set of structs for which we generate legacy definitions.

Most of the things in af-structs.h are not used, and fixing the names
of some of them causes bad name collisions due to lack of namespacing.
Just stop generating all of them except the ones we really use.

* Address review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app github integrations review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @tcarmelveilleux @andy31415 @msandstedt @jtung-apple