[nrfconnect] Bump nRF Connect SDK to 2.2.0 #24302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Damian-Nordic
commented
Jan 6, 2023
Damian-Nordic
commented
- Bump recommended nRF Connect SDK version to 2.2.0
- Bring in fixes to the platform code (mainly Wi-Fi support)
- Align examples with samples included in NCS 2.2.0
- Update workflows to use newest Docker images.
|
|
github-actions
bot
added
config
examples
github
integrations
nrf connect
platform
test driver
workflows
zephyr
labels
|
PR #24302: Size comparison from e766102 to e8bf721 Increases above 0.2%:
Increases (18 builds for bl602, bl702, esp32, nrfconnect)
Decreases (16 builds for bl602, esp32, nrfconnect, psoc6, telink)
Full report (65 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@Damian-Nordic needs restyle and CLA signature from stephanosio |
Change the recommended nRF Connect SDK version to v2.2.0.
- replace wpa_supplicant API calls with generic Zephyr net_mgmt API - use net events to manage WiFi connection - refactoring of the whole platform/nrfconnect/wifi code Signed-off-by: Marcin Kajor <[email protected]>
With the current net_mgmt API it is necessary to scan networks to get the security mode supported by an AP which we want to connect with. Also fixed the invalid handling of net_mgmt event life time. Signed-off-by: Marcin Kajor <[email protected]>
These changes were implied the the recent Zephyr upmerge: - updates of Zephyr include paths - removal of disabling of gpio1 in board DTS overlays - fix for the possible dangling pointer compilation error after gcc got more picky about that (v10.3 vs. v12.1) Signed-off-by: Marcin Kajor <[email protected]>
This is a workaround for the non-unreferenced BLE connection object when restarting advertising in BLE disconnect callback. Signed-off-by: Marcin Kajor <[email protected]>
Make sure the fail-safe works as expected with WiFi networking: - disconnect when reverting the configuration - always cleanup the provisioning data structures before connecting to avoid dummy buffer overwriting and data length issues Signed-off-by: Marcin Kajor <[email protected]>
Router Solicitation is not sent after connecting to the Wi-Fi network by the Wi-Fi driver, so in result Thread Border Router doesn't send Router Advertisement to the device. As a workaround sending RS was added in the Matter platform code.
We can now use this feature in spite of stats still not being implemented. Signed-off-by: Marcin Kajor <[email protected]>
Fix build with CHIP_MALLOC_SYS_HEAP Kconfig option that replaces default malloc/free with alternatives based on Zephyr's sys_heap. Signed-off-by: Damian Krolik <[email protected]>
* Increase the SYSTEM_WORKQUEUE_STACK_SIZE to match supplicant needs * Decrease the connection timeout to be lower than failsafe (35s) * Adapt WiFiRequestStatus to follow supplicant implementation * All of above makes the failsafe more robust Signed-off-by: Marcin Kajor <[email protected]>
Do not disconnect/reconnect to the already attached network. Signed-off-by: Marcin Kajor <[email protected]>
This commit updates the chip-module build configurations to define `_DEFAULT_SOURCE` when compiling Matter because it uses non-standard functions that are only available when `_DEFAULT_SOURCE` is defined. Note that this used to be not necessary only because of a quirk in the way Newlib handles the feature test macro, which resulted in Newlib defining `_DEFAULT_SOURCE` when compiling with `-std=gnu`. For more details, refer to the issue zephyrproject-rtos/zephyr#52739.
pullapprove
bot
requested review from
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
|
PR #24302: Size comparison from b953c0b to 3ebc55c Increases above 0.2%:
Increases (17 builds for cc13x2_26x2, esp32, nrfconnect)
Decreases (21 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (55 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 9, 2023
|
PR #24302: Size comparison from ffc8d97 to b95a710 Increases above 0.2%:
Increases (22 builds for bl602, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6)
Decreases (18 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (55 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cletnick
pushed a commit
to cletnick/connectedhomeip
that referenced
this pull request
Jan 10, 2023
* [nrfconnect] Bump nRF Connect SDK to 2.2.0 Change the recommended nRF Connect SDK version to v2.2.0. * Start using Zephyr WiFi net_mgmt API and events - replace wpa_supplicant API calls with generic Zephyr net_mgmt API - use net events to manage WiFi connection - refactoring of the whole platform/nrfconnect/wifi code Signed-off-by: Marcin Kajor <[email protected]> * Implemented proper handling of WiFi security modes. With the current net_mgmt API it is necessary to scan networks to get the security mode supported by an AP which we want to connect with. Also fixed the invalid handling of net_mgmt event life time. Signed-off-by: Marcin Kajor <[email protected]> * Aligned Matter SDK to Zephyr 0.15.x revision. These changes were implied the the recent Zephyr upmerge: - updates of Zephyr include paths - removal of disabling of gpio1 in board DTS overlays - fix for the possible dangling pointer compilation error after gcc got more picky about that (v10.3 vs. v12.1) Signed-off-by: Marcin Kajor <[email protected]> * Increased the max number of BLE connections. This is a workaround for the non-unreferenced BLE connection object when restarting advertising in BLE disconnect callback. Signed-off-by: Marcin Kajor <[email protected]> * WiFi fail-safe related fixes Make sure the fail-safe works as expected with WiFi networking: - disconnect when reverting the configuration - always cleanup the provisioning data structures before connecting to avoid dummy buffer overwriting and data length issues Signed-off-by: Marcin Kajor <[email protected]> * Introduced a workaround to send Router Solicitation after connect Router Solicitation is not sent after connecting to the Wi-Fi network by the Wi-Fi driver, so in result Thread Border Router doesn't send Router Advertisement to the device. As a workaround sending RS was added in the Matter platform code. * Forward the channel number and RSSI from WIFiManager. We can now use this feature in spite of stats still not being implemented. Signed-off-by: Marcin Kajor <[email protected]> * Minor fixes for heap usage Fix build with CHIP_MALLOC_SYS_HEAP Kconfig option that replaces default malloc/free with alternatives based on Zephyr's sys_heap. Signed-off-by: Damian Krolik <[email protected]> * Wi-Fi status handling fixes. * Increase the SYSTEM_WORKQUEUE_STACK_SIZE to match supplicant needs * Decrease the connection timeout to be lower than failsafe (35s) * Adapt WiFiRequestStatus to follow supplicant implementation * All of above makes the failsafe more robust Signed-off-by: Marcin Kajor <[email protected]> * wifi: RevertConfiguration optimization. Do not disconnect/reconnect to the already attached network. Signed-off-by: Marcin Kajor <[email protected]> * Define _DEFAULT_SOURCE This commit updates the chip-module build configurations to define `_DEFAULT_SOURCE` when compiling Matter because it uses non-standard functions that are only available when `_DEFAULT_SOURCE` is defined. Note that this used to be not necessary only because of a quirk in the way Newlib handles the feature test macro, which resulted in Newlib defining `_DEFAULT_SOURCE` when compiling with `-std=gnu`. For more details, refer to the issue zephyrproject-rtos/zephyr#52739. * Align examples with samples included in nRF Connect SDK 2.2.0 * Update remaining Docker images to 0.6.27 * Restyled by clang-format * Restyled by shellharden Signed-off-by: Marcin Kajor <[email protected]> Signed-off-by: Damian Krolik <[email protected]> Co-authored-by: Marcin Kajor <[email protected]> Co-authored-by: Kamil Kasperczyk <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [nrfconnect] Bump nRF Connect SDK to 2.2.0 Change the recommended nRF Connect SDK version to v2.2.0. * Start using Zephyr WiFi net_mgmt API and events - replace wpa_supplicant API calls with generic Zephyr net_mgmt API - use net events to manage WiFi connection - refactoring of the whole platform/nrfconnect/wifi code Signed-off-by: Marcin Kajor <[email protected]> * Implemented proper handling of WiFi security modes. With the current net_mgmt API it is necessary to scan networks to get the security mode supported by an AP which we want to connect with. Also fixed the invalid handling of net_mgmt event life time. Signed-off-by: Marcin Kajor <[email protected]> * Aligned Matter SDK to Zephyr 0.15.x revision. These changes were implied the the recent Zephyr upmerge: - updates of Zephyr include paths - removal of disabling of gpio1 in board DTS overlays - fix for the possible dangling pointer compilation error after gcc got more picky about that (v10.3 vs. v12.1) Signed-off-by: Marcin Kajor <[email protected]> * Increased the max number of BLE connections. This is a workaround for the non-unreferenced BLE connection object when restarting advertising in BLE disconnect callback. Signed-off-by: Marcin Kajor <[email protected]> * WiFi fail-safe related fixes Make sure the fail-safe works as expected with WiFi networking: - disconnect when reverting the configuration - always cleanup the provisioning data structures before connecting to avoid dummy buffer overwriting and data length issues Signed-off-by: Marcin Kajor <[email protected]> * Introduced a workaround to send Router Solicitation after connect Router Solicitation is not sent after connecting to the Wi-Fi network by the Wi-Fi driver, so in result Thread Border Router doesn't send Router Advertisement to the device. As a workaround sending RS was added in the Matter platform code. * Forward the channel number and RSSI from WIFiManager. We can now use this feature in spite of stats still not being implemented. Signed-off-by: Marcin Kajor <[email protected]> * Minor fixes for heap usage Fix build with CHIP_MALLOC_SYS_HEAP Kconfig option that replaces default malloc/free with alternatives based on Zephyr's sys_heap. Signed-off-by: Damian Krolik <[email protected]> * Wi-Fi status handling fixes. * Increase the SYSTEM_WORKQUEUE_STACK_SIZE to match supplicant needs * Decrease the connection timeout to be lower than failsafe (35s) * Adapt WiFiRequestStatus to follow supplicant implementation * All of above makes the failsafe more robust Signed-off-by: Marcin Kajor <[email protected]> * wifi: RevertConfiguration optimization. Do not disconnect/reconnect to the already attached network. Signed-off-by: Marcin Kajor <[email protected]> * Define _DEFAULT_SOURCE This commit updates the chip-module build configurations to define `_DEFAULT_SOURCE` when compiling Matter because it uses non-standard functions that are only available when `_DEFAULT_SOURCE` is defined. Note that this used to be not necessary only because of a quirk in the way Newlib handles the feature test macro, which resulted in Newlib defining `_DEFAULT_SOURCE` when compiling with `-std=gnu`. For more details, refer to the issue zephyrproject-rtos/zephyr#52739. * Align examples with samples included in nRF Connect SDK 2.2.0 * Update remaining Docker images to 0.6.27 * Restyled by clang-format * Restyled by shellharden Signed-off-by: Marcin Kajor <[email protected]> Signed-off-by: Damian Krolik <[email protected]> Co-authored-by: Marcin Kajor <[email protected]> Co-authored-by: Kamil Kasperczyk <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.