-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] InitArguments is off by one for global commands #24299
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_InitArgumentsOffByOneForGlobalCommand
Jan 12, 2023
Merged
[chip-tool] InitArguments is off by one for global commands #24299
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_InitArgumentsOffByOneForGlobalCommand
Jan 12, 2023
+44
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24299: Size comparison from 7f668cd to 1064c9b Increases (8 builds for bl602, bl702, cc13x2_26x2, linux, telink)
Decreases (7 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 6, 2023
1064c9b
to
633b64f
Compare
PR #24299: Size comparison from 5ec8da8 to 633b64f Increases (8 builds for cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, linux, psoc6, qpg, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
633b64f
to
d563270
Compare
d563270
to
d0f4934
Compare
PR #24299: Size comparison from 18d3671 to d0f4934 Increases (8 builds for bl702, cc13x2_26x2, efr32, linux, telink)
Decreases (10 builds for cc13x2_26x2, cyw30739, esp32, linux, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The argument parsing code for
chip-tool
overrides theattr-name
/event-name
argument of global command (read
,write
,subscribe
,read-event
,subscribe-event
) which is already setup during the command definition.