-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better align naming in General Diagnostics cluster XML with the spec. #24292
Merged
andy31415
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-general-diagnostics
Jan 9, 2023
Merged
Better align naming in General Diagnostics cluster XML with the spec. #24292
andy31415
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-general-diagnostics
Jan 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk and
saurabhst
January 5, 2023 21:00
github-actions
bot
added
app
controller
darwin
examples
github
platform
tests
workflows
labels
Jan 5, 2023
PR #24292: Size comparison from fbaa1fe to bf989ea Increases (4 builds for bl602, bl702, linux)
Decreases (3 builds for bl702, linux)
Full report (9 builds for bl602, bl702, k32w, linux)
|
bzbarsky-apple
force-pushed
the
rename-general-diagnostics
branch
from
January 5, 2023 22:10
bf989ea
to
c80ebfd
Compare
PR #24292: Size comparison from fbaa1fe to c80ebfd Increases (14 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (14 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, qpg, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
|
This will need a fix for project-chip/zap#883 and another fix on top of that in Matter to actually compile. |
bzbarsky-apple
force-pushed
the
rename-general-diagnostics
branch
from
January 7, 2023 00:06
c80ebfd
to
708b965
Compare
PR #24292: Size comparison from 8c7c641 to 708b965 Increases (12 builds for bl602, bl702, esp32, linux, psoc6, telink)
Decreases (11 builds for bl702, cyw30739, esp32, linux, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/general-diagnostics-cluster.xml
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Jan 7, 2023
jtung-apple
approved these changes
Jan 7, 2023
ReneJosefsen
approved these changes
Jan 9, 2023
cletnick
pushed a commit
to cletnick/connectedhomeip
that referenced
this pull request
Jan 10, 2023
…project-chip#24292) * Align naming in General Diagnostics cluster XML with the spec better. * Update ZAP files with the new attribute name and type. * Regenerate generated files.
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…project-chip#24292) * Align naming in General Diagnostics cluster XML with the spec better. * Update ZAP files with the new attribute name and type. * Regenerate generated files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.