Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move weakly typed enum list back into Matter repository. #24270

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Move weakly typed enum list back into Matter repository. #24270

merged 1 commit into from
Jan 5, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Instead of hardcoding this list in the helper (in the ZAP repository), it should be data in the Matter repository. Then we can remove things from the list without having to synchronize with ZAP changes.

This change on its own does not make ZAP use this YAML instead of the hardcoded list; that will need to be a separate ZAP change after this merges.

The list comes from https://github.com/project-chip/zap/blob/d785a5be53a7ec1a79f9c1aa4f4857a24c4acfd5/src-electron/generator/matter/app/zap-templates/templates/app/helper.js#L796-L832

@bzbarsky-apple
Move weakly typed enum list back into Matter repository.
5c66b5e 
Instead of hardcoding this list in the helper (in the ZAP repository),
it should be data in the Matter repository.  Then we can remove things
from the list without having to synchronize with ZAP changes.

This change on its own does not make ZAP use this YAML instead of the
hardcoded list; that will need to be a separate ZAP change after this
merges.
@github-actions github-actions bot added the app label Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 4, 2023 •
edited
Loading

PR #24270: Size comparison from b921798 to 5c66b5e

Increases (5 builds for bl702, cc13x2_26x2, esp32, psoc6)
platform target config section b921798 5c66b5e change % change
bl702 lighting-app bl702 .debug_info 39729136 39729137 1 0.0
.text 955880 955882 2 0.0
bl702+rpc .debug_info 44096041 44096042 1 0.0
.text 1032680 1032682 2 0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 644123 644131 8 0.0
.text 564664 564672 8 0.0
esp32 all-clusters-app c3devkit (read/write) 1791034 1791050 16 0.0
.flash.rodata 248472 248488 16 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22286943 22286945 2 0.0
Decreases (3 builds for bl602, psoc6, telink)
platform target config section b921798 5c66b5e change % change
bl602 lighting-app bl602+rpc .text 1051992 1051990 -2 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22505303 22505301 -2 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1068540 1068532 -8 -0.0
text 724610 724608 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section b921798 5c66b5e change % change
bl602 lighting-app bl602 (read/write) 1343498 1343498 0 0.0
.bss 86510 86510 0 0.0
.data 9584 9584 0 0.0
.text 1021038 1021038 0 0.0
bl602+rpc (read/write) 1388946 1388946 0 0.0
.bss 94550 94550 0 0.0
.data 9976 9976 0 0.0
.text 1051992 1051990 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1194831 1194831 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1532720 1532720 0 0.0
.debug_aranges 132536 132536 0 0.0
.debug_frame 486548 486548 0 0.0
.debug_info 39729136 39729137 1 0.0
.debug_line 5208066 5208066 0 0.0
.debug_loc 3387429 3387429 0 0.0
.debug_ranges 363760 363760 0 0.0
.debug_str 3503512 3503512 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 116400 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569359 569359 0 0.0
.symtab 172000 172000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955880 955882 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1286883 1286883 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1680670 1680670 0 0.0
.debug_aranges 140664 140664 0 0.0
.debug_frame 514080 514080 0 0.0
.debug_info 44096041 44096042 1 0.0
.debug_line 5604599 5604599 0 0.0
.debug_loc 3582693 3582693 0 0.0
.debug_ranges 387368 387368 0 0.0
.debug_str 3906047 3906047 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130848 130848 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629948 629948 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1032680 1032682 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679875 679875 0 0.0
(read/write) 171572 171572 0 0.0
.bss 81140 81140 0 0.0
.data 3380 3380 0 0.0
.rodata 89995 89995 0 0.0
.text 589568 589568 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644123 644131 8 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79139 79139 0 0.0
.text 564664 564672 8 0.0
lock-ftd LP_CC2652R7 (read only) 677087 677087 0 0.0
(read/write) 171920 171920 0 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 77415 0 0.0
.text 599192 599192 0 0.0
lock-mtd LP_CC2652R7 (read only) 662195 662195 0 0.0
(read/write) 182076 182076 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 103507 0 0.0
.text 558208 558208 0 0.0
pump-app LP_CC2652R7 (read only) 690223 690223 0 0.0
(read/write) 159520 159520 0 0.0
.bss 78756 78756 0 0.0
.data 3268 3268 0 0.0
.rodata 91103 91103 0 0.0
.text 598636 598636 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674035 674035 0 0.0
(read/write) 175812 175812 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86587 86587 0 0.0
.text 586968 586968 0 0.0
shell LP_CC2652R7 (read only) 671098 671098 0 0.0
(read/write) 182676 182676 0 0.0
.bss 83468 83468 0 0.0
.data 3376 3376 0 0.0
.rodata 86738 86738 0 0.0
.text 584044 584044 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588146 588146 0 0.0
.app_xip_area 464492 464492 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591974 591974 0 0.0
.app_xip_area 463024 463024 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551830 551830 0 0.0
.app_xip_area 433664 433664 0 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976468 976468 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 822108 822108 0 0.0
BRD4161A+rs911x (read/write) 1039056 1039056 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 850376 850376 0 0.0
BRD4187C (read/write) 1149924 1149924 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 984244 984244 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069168 1069168 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 908940 908940 0 0.0
window-app BRD4187C (read/write) 1142568 1142568 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 975448 975448 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219518 1219518 0 0.0
(read/write) 1791034 1791050 16 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248472 248488 16 0.0
.flash.text 1219518 1219518 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233423 1233423 0 0.0
(read/write) 564267 564267 0 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314260 314260 0 0.0
.flash.text 1228039 1228039 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662652 662652 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 564404 564404 0 0.0
light k32w0+release (read/write) 673352 673352 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 593740 593740 0 0.0
lock k32w0+release (read/write) 634196 634196 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 553804 553804 0 0.0
linux all-clusters-app debug (read only) 3115481 3115481 0 0.0
(read/write) 158568 158568 0 0.0
.bss 62432 62432 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87240 87240 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281835 281835 0 0.0
.text 2648962 2648962 0 0.0
all-clusters-minimal-app debug (read only) 2938921 2938921 0 0.0
(read/write) 149968 149968 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79608 79608 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 281227 281227 0 0.0
.text 2476050 2476050 0 0.0
bridge-app debug (read only) 2497897 2497897 0 0.0
(read/write) 133088 133088 0 0.0
.bss 52512 52512 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 70696 70696 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 212512 212512 0 0.0
.text 2113602 2113602 0 0.0
chip-tool debug (read only) 11152321 11152321 0 0.0
(read/write) 646880 646880 0 0.0
.bss 25880 25880 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 611648 611648 0 0.0
.dynamic 608 608 0 0.0
.got 5192 5192 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 606309 606309 0 0.0
.text 9046836 9046836 0 0.0
chip-tool-ipv6only arm64 (read only) 10567108 10567108 0 0.0
(read/write) 696104 696104 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 640528 640528 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 535764 535764 0 0.0
.text 8382884 8382884 0 0.0
lighting-app debug+rpc (read only) 2665153 2665153 0 0.0
(read/write) 132456 132456 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 74024 74024 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228448 228448 0 0.0
.text 2259954 2259954 0 0.0
lock-app debug (read only) 2624249 2624249 0 0.0
(read/write) 127440 127440 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70936 70936 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244680 244680 0 0.0
.text 2207666 2207666 0 0.0
ota-provider-app debug (read only) 2198169 2198169 0 0.0
(read/write) 105872 105872 0 0.0
.bss 46560 46560 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 52120 52120 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 196008 196008 0 0.0
.text 1862258 1862258 0 0.0
ota-requestor-app debug (read only) 2359753 2359753 0 0.0
(read/write) 113920 113920 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57208 57208 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202704 202704 0 0.0
.text 2008146 2008146 0 0.0
shell debug (read only) 2647809 2647809 0 0.0
(read/write) 143032 143032 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78136 78136 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 240050 240050 0 0.0
.text 2248050 2248050 0 0.0
thermostat-no-ble arm64 (read only) 2479276 2479276 0 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149704 149704 0 0.0
.text 2068976 2068976 0 0.0
tv-app debug (read only) 3287569 3287569 0 0.0
(read/write) 262280 262280 0 0.0
.bss 170776 170776 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80544 80544 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 269080 269080 0 0.0
.text 2824162 2824162 0 0.0
tv-casting-app debug (read only) 5610097 5610097 0 0.0
(read/write) 162640 162640 0 0.0
.bss 52152 52152 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101960 101960 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 360345 360345 0 0.0
.text 4972162 4972162 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464000 2464000 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1426644 1426644 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1169987 1169987 0 0.0
bss 143621 143621 0 0.0
rodata 136368 136368 0 0.0
text 810132 810132 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1349118 1349118 0 0.0
bss 105132 105132 0 0.0
rodata 204292 204292 0 0.0
text 755184 755184 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1115615 1115615 0 0.0
bss 142856 142856 0 0.0
rodata 112684 112684 0 0.0
text 780288 780288 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842056 842056 0 0.0
(read/write) 1749796 1749796 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238094 1238094 0 0.0
.debug_aranges 110816 110816 0 0.0
.debug_frame 372184 372184 0 0.0
.debug_info 2709343 2709343 0 0.0
.debug_line 3722947 3722947 0 0.0
.debug_loc 3627724 3627724 0 0.0
.debug_ranges 346640 346640 0 0.0
.debug_str 3459098 3459098 0 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 572583 572583 0 0.0
.symtab 422128 422128 0 0.0
.text 1550120 1550120 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1692324 1692324 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229985 1229985 0 0.0
.debug_aranges 110288 110288 0 0.0
.debug_frame 375240 375240 0 0.0
.debug_info 26829866 26829866 0 0.0
.debug_line 3741845 3741845 0 0.0
.debug_loc 3615330 3615330 0 0.0
.debug_ranges 345256 345256 0 0.0
.debug_str 3448110 3448110 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536672 536672 0 0.0
.symtab 408560 408560 0 0.0
.text 1493376 1493376 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1610540 1610540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064762 1064762 0 0.0
.debug_aranges 102488 102488 0 0.0
.debug_frame 345572 345572 0 0.0
.debug_info 22286943 22286945 2 0.0
.debug_line 3306872 3306872 0 0.0
.debug_loc 3313221 3313221 0 0.0
.debug_ranges 309392 309392 0 0.0
.debug_str 3253696 3253696 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472997 472997 0 0.0
.symtab 376928 376928 0 0.0
.text 1419784 1419784 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1644476 1644476 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066580 1066580 0 0.0
.debug_aranges 102872 102872 0 0.0
.debug_frame 347372 347372 0 0.0
.debug_info 22505303 22505301 -2 -0.0
.debug_line 3307985 3307985 0 0.0
.debug_loc 3334760 3334760 0 0.0
.debug_ranges 311248 311248 0 0.0
.debug_str 3269534 3269534 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475714 475714 0 0.0
.symtab 378928 378928 0 0.0
.text 1448728 1448728 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150868 1150868 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 597968 597968 0 0.0
lock-app qpg6105+debug (read/write) 1117476 1117476 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 564572 564572 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1068540 1068532 -8 -0.0
bss 97632 97632 0 0.0
text 724610 724608 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1007832 1007832 0 0.0
bss 96856 96856 0 0.0
text 689766 689766 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 929280 929280 0 0.0
bss 89104 89104 0 0.0
text 636374 636374 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1007240 1007240 0 0.0
bss 97156 97156 0 0.0
text 702152 702152 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 942868 942868 0 0.0
bss 90052 90052 0 0.0
text 647628 647628 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932436 932436 0 0.0
bss 90496 90496 0 0.0
text 637072 637072 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 191b0b5 into project-chip:master Jan 5, 2023
@bzbarsky-apple bzbarsky-apple deleted the move-enum-list-data branch January 5, 2023 12:26
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Move weakly typed enum list back into Matter repository. (project-chi…
80df251 
…p#24270)

Instead of hardcoding this list in the helper (in the ZAP repository),
it should be data in the Matter repository.  Then we can remove things
from the list without having to synchronize with ZAP changes.

This change on its own does not make ZAP use this YAML instead of the
hardcoded list; that will need to be a separate ZAP change after this
merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @tcarmelveilleux @arkq