-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Disable selected BLE features and RTT #24227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable encryption and EC in BLE controller, and JLink RTT in all nRF Connect examples. BLE changes save over 5.5kB of flash and almost 2kB of RAM. Disabling RTT saves over 1kB of RAM, additionally. Signed-off-by: Damian Krolik <[email protected]>
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
mlepage-google and
mrjerryjohns
January 2, 2023 09:24
pullapprove
bot
requested review from
msandstedt,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 2, 2023 09:24
kkasperczyk-no
approved these changes
Jan 2, 2023
PR #24227: Size comparison from 19c8ea4 to e1ca70d Increases (12 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (17 builds for cyw30739, esp32, nrfconnect, telink)
Full report (64 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
LuDuda
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
andy31415
approved these changes
Jan 4, 2023
Damian-Nordic
added a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 1, 2023
…oject-chip#24227) Disable encryption and EC in BLE controller, and JLink RTT in all nRF Connect examples. BLE changes save over 5.5kB of flash and almost 2kB of RAM. Disabling RTT saves over 1kB of RAM, additionally. Signed-off-by: Damian Krolik <[email protected]> Signed-off-by: Damian Krolik <[email protected]> (cherry picked from commit 99a8de7)
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 1, 2023
… RTT (project-chip#24227)" This reverts commit a1fbffa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable encryption and EC in BLE controller, and JLink RTT in all nRF Connect examples. BLE changes save over 5.5kB of flash and almost 2kB of RAM. Disabling RTT saves over 1kB of RAM, additionally.