[crypto] Added Method That Finds and Replaces Resigned Version of a Certificate #24212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #24212: Size comparison from 19c8ea4 to e5fd16c Increases (9 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (4 builds for bl602, cc13x2_26x2, telink)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
emargolis
force-pushed
the
emargolis/feature/method-to-find-same-resigned-cert
branch
from
e5fd16c to
3d96c15
Compare
|
PR #24212: Size comparison from 19c8ea4 to 3d96c15 Increases (14 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (1 build for nrfconnect)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
emargolis
force-pushed
the
emargolis/feature/method-to-find-same-resigned-cert
branch
from
3d96c15 to
fa26fc8
Compare
|
PR #24212: Size comparison from 9a1c31c to fa26fc8 Increases (11 builds for bl702, cyw30739, esp32, psoc6, telink)
Decreases (3 builds for bl702, esp32, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ertificate. This method checks for resigned version of the reference certificate in the list and returns it. The following conditions SHOULD be satisfied for the certificate to qualify as a resigned version of a reference certificate: - SKID of the candidate and the reference certificate should match. - SubjectDN of the candidate and the reference certificate should match. There is no specific use case for this method in Matter. However, specific ecosystem implementations may find this method useful. Some of the potential use cases could be finding resigned version of a PAI or DAC certificate. Also, this method can be useful when Matter introduces attestation certificate revocation mechanism.
emargolis
force-pushed
the
emargolis/feature/method-to-find-same-resigned-cert
branch
from
fa26fc8 to
5143e8d
Compare
bzbarsky-apple
approved these changes
Jan 4, 2023
|
PR #24212: Size comparison from b921798 to 5143e8d Increases (8 builds for bl702, cc13x2_26x2, telink)
Decreases (4 builds for bl602, cc13x2_26x2, nrfconnect)
Full report (33 builds for bl602, bl702, cc13x2_26x2, efr32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 4, 2023
|
PR #24212: Size comparison from b921798 to b74ddd4 Increases above 0.2%:
Increases (25 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (42 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ertificate (project-chip#24212) * [crypto] Added Method That Finds and Replaces Resigned Version of a Certificate. This method checks for resigned version of the reference certificate in the list and returns it. The following conditions SHOULD be satisfied for the certificate to qualify as a resigned version of a reference certificate: - SKID of the candidate and the reference certificate should match. - SubjectDN of the candidate and the reference certificate should match. There is no specific use case for this method in Matter. However, specific ecosystem implementations may find this method useful. Some of the potential use cases could be finding resigned version of a PAI or DAC certificate. Also, this method can be useful when Matter introduces attestation certificate revocation mechanism. * Updated function description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24211
This method checks for resigned version of the reference certificate in the list and returns it.
The following conditions SHOULD be satisfied for the certificate to qualify as a resigned version of a reference certificate:
There is no specific use case for this method in Matter. However, specific ecosystem implementations may find this method useful.
Some of the potential use cases could be finding resigned version of a PAI or DAC certificate.
Also, this method can be useful when Matter introduces attestation certificate revocation mechanism.