-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Identify cluster XML with the spec. #24173
Merged
Damian-Nordic
merged 3 commits into
project-chip:master
from
bzbarsky-apple:identify-naming
Dec 22, 2022
Merged
Align naming in Identify cluster XML with the spec. #24173
Damian-Nordic
merged 3 commits into
project-chip:master
from
bzbarsky-apple:identify-naming
Dec 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
December 21, 2022 16:47
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple and
xylophone21
December 21, 2022 16:47
PR #24173: Size comparison from 74296b8 to ab91fb0 Increases (2 builds for nrfconnect, telink)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
identify-naming
branch
from
December 21, 2022 18:35
ab91fb0
to
61df106
Compare
PR #24173: Size comparison from 74296b8 to 61df106 Decreases (2 builds for linux, qpg)
Full report (8 builds for k32w, linux, mbed, qpg)
|
bzbarsky-apple
force-pushed
the
identify-naming
branch
from
December 21, 2022 19:08
61df106
to
aa88c15
Compare
PR #24173: Size comparison from 74296b8 to aa88c15 Increases (4 builds for bl602, cc13x2_26x2, nrfconnect, psoc6)
Decreases (10 builds for bl602, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
approved these changes
Dec 22, 2022
arkq
approved these changes
Dec 22, 2022
Damian-Nordic
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manual changes are in the first changeset.
The second and third changesets are auto-generated by running zap_convert_all.py and zap_regen_all.py respectively.