-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for renaming fields in Darwin codegen. #24154
Merged
bzbarsky-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:darwin-field-renaming
Jan 3, 2023
Merged
Implement support for renaming fields in Darwin codegen. #24154
bzbarsky-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:darwin-field-renaming
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
franck-apple
December 20, 2022 18:10
pullapprove
bot
requested review from
yunhanw-google,
robszewczyk,
xylophone21,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple and
woody-apple
December 20, 2022 18:10
PR #24154: Size comparison from fb18595 to 23cccc6 Increases (10 builds for bl702, esp32, psoc6, telink)
Decreases (4 builds for bl602, nrfconnect, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This adds support for renaming struct, event, and command fields. Also fixes a bug that was introduced where the getter for newPosition was mis-named.
bzbarsky-apple
force-pushed
the
darwin-field-renaming
branch
from
December 21, 2022 20:52
23cccc6
to
34d95d6
Compare
PR #24154: Size comparison from 74296b8 to 34d95d6 Increases (2 builds for cc13x2_26x2, nrfconnect)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24154: Size comparison from 74296b8 to d406f01 Increases (5 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24154: Size comparison from 74296b8 to bc836e0 Increases above 0.2%:
Increases (5 builds for bl602, cc13x2_26x2, linux, nrfconnect, telink)
Decreases (9 builds for cc13x2_26x2, esp32, k32w, linux, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24154: Size comparison from 74296b8 to ee546ff Increases above 0.2%:
Increases (21 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, k32w, linux, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
approved these changes
Jan 3, 2023
Fast-tracking platform-specific change with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for renaming struct, event, and command fields.
Also fixes a bug that was introduced where the getter for newPosition was mis-named.
For events and structs, we just put the shims for the old name directly on the most-recent struct interface (which any deprecated versions inherit from, so they pick it up too).
For commands, we try hard to put the deprecated shims on the deprecated interface if there is one. This is nicer in terms of the APIs it produces, but quite a bit more complex in terms of the templates.
Thoughts on which approach is better are much appreciated.