-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python packaging idl and yamltests #24140
Merged
andy31415
merged 14 commits into
project-chip:master
from
tehampson:python-packaging-idl-and-yamltests
Jan 5, 2023
Merged
Python packaging idl and yamltests #24140
andy31415
merged 14 commits into
project-chip:master
from
tehampson:python-packaging-idl-and-yamltests
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
December 19, 2022 22:45
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
December 19, 2022 22:45
PR #24140: Size comparison from ca086f2 to 4e51b66 Increases (4 builds for cc13x2_26x2, cyw30739, esp32, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
force-pushed
the
python-packaging-idl-and-yamltests
branch
from
December 20, 2022 14:25
4e51b66
to
f87c4b3
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Dec 20, 2022
PR #24140: Size comparison from 50e7c19 to db06e65 Increases (11 builds for cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Decreases (5 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
commented
Dec 20, 2022
andy31415
approved these changes
Jan 4, 2023
PR #24140: Size comparison from 1dd6520 to 651082e Increases above 0.2%:
Increases (25 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (41 builds for bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
approved these changes
Jan 5, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Initial attempt at modularizing python packages in scripts * Put packages into separate directories with stutter * hopefully fix codegen path to idl * Fix issue with building yamltests_distribution * Hopefully fix CI * Hopefully fix CI * Hopefully fix CI * Restyle * Hopefully fix CI * Restyle * Remove directory repitition and prepend matter to py package names * Restyle * Restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
github
gn
review - approved
scripts
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
scripts/yamltest
is dependent onscripts/idl
scripts/idl
is not properly structured as per pigweed's GN Structure for Python Code recommendationidl
foryamltest
to import.idl
. The current directory structure give a top level multiple top level modulesgenerators
,lint
, andzapxml
, which we actually want to be want to be nested modules foridl
).yamltest
is a distributable python package that include theidl
dependency for potential use in test harness and also within the build system for CI testing.Solution:
yamltests_distribution
package install as a part of bootstrapping so module can be used by python-repl CI testing.Test:
yamltests_distribution
whl that we are able to run some of the yamltest unittests