-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SILABS] Folder structure and build system re-factoring for thermostat #24134
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
nipatel-silabs:build_system_re-factoring_for_thermostat
Jan 6, 2023
Merged
[SILABS] Folder structure and build system re-factoring for thermostat #24134
jepenven-silabs
merged 2 commits into
project-chip:master
from
nipatel-silabs:build_system_re-factoring_for_thermostat
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24134: Size comparison from 04c20f6 to 2141491 Increases (6 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (9 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24134: Size comparison from ca086f2 to 46decb2 Increases (4 builds for bl602, cyw30739, psoc6, telink)
Decreases (5 builds for bl702, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
approved these changes
Dec 20, 2022
bzbarsky-apple
approved these changes
Dec 20, 2022
@nipatel-silabs please sign the CLA |
andy31415
approved these changes
Jan 4, 2023
pullapprove
bot
requested review from
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
saurabhst and
selissia
January 5, 2023 16:46
selissia
approved these changes
Jan 5, 2023
ok I have done it. |
cletnick
pushed a commit
to cletnick/connectedhomeip
that referenced
this pull request
Jan 10, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/Changes done:
re-factoring for thermostat application to adapt according to silabs changed folder
Previously we had efr32 folder now changed to silabs/efr32
Testing Done:
basic sanity on below combos-
MG12+wf200
MG12+rs9116
MG24+wf200
MG24+rs9116