Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow markdown in issue template descriptions. #24085

Conversation

bzbarsky-apple
Copy link
Contributor

Instead of forcing preformatting on the text people type as their reproduction steps, allow them to type markdown and nudge toward using proper formatting and attaching logs as files via the placeholder.

Instead of forcing preformatting on the text people type as their
reproduction steps, allow them to type markdown and nudge toward using
proper formatting and attaching logs as files via the placeholder.
@github-actions
Copy link

github-actions bot commented Dec 14, 2022

PR #24085: Size comparison from 5b3c08a to 3dddef7

Increases (2 builds for esp32, telink)
platform target config section 5b3c08a 3dddef7 change % change
esp32 all-clusters-app m5stack (read/write) 564095 564099 4 0.0
.flash.rodata 314088 314092 4 0.0
telink thermostat tlsr9518adk80d (read/write) 934756 934764 8 0.0
text 638144 638146 2 0.0
Decreases (8 builds for bl602, bl702, psoc6, telink)
platform target config section 5b3c08a 3dddef7 change % change
bl602 lighting-app bl602 .text 1038256 1038254 -2 -0.0
bl602+rpc .text 1069676 1069674 -2 -0.0
bl702 lighting-app bl702 .debug_info 39182839 39182838 -1 -0.0
.text 955944 955942 -2 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22471735 22471734 -1 -0.0
telink all-clusters-app tlsr9518adk80d text 725678 725674 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d text 690840 690838 -2 -0.0
lighting-app tlsr9518adk80d text 703238 703236 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 945220 945212 -8 -0.0
text 648718 648716 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5b3c08a 3dddef7 change % change
bl602 lighting-app bl602 (read/write) 1355450 1355450 0 0.0
.bss 86977 86977 0 0.0
.data 9984 9984 0 0.0
.text 1038256 1038254 -2 -0.0
bl602+rpc (read/write) 1401234 1401234 0 0.0
.bss 95017 95017 0 0.0
.data 10384 10384 0 0.0
.text 1069676 1069674 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195359 1195359 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67102 67102 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1528873 1528873 0 0.0
.debug_aranges 132544 132544 0 0.0
.debug_frame 486348 486348 0 0.0
.debug_info 39182839 39182838 -1 -0.0
.debug_line 5147392 5147392 0 0.0
.debug_loc 3379013 3379013 0 0.0
.debug_ranges 363440 363440 0 0.0
.debug_str 3479385 3479385 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116352 116352 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568817 568817 0 0.0
.symtab 172128 172128 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955944 955942 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283835 1283835 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75118 75118 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1676289 1676289 0 0.0
.debug_aranges 140664 140664 0 0.0
.debug_frame 513764 513764 0 0.0
.debug_info 43475237 43475237 0 0.0
.debug_line 5536789 5536789 0 0.0
.debug_loc 3573716 3573716 0 0.0
.debug_ranges 386976 386976 0 0.0
.debug_str 3881792 3881792 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130096 130096 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629101 629101 0 0.0
.symtab 190304 190304 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029920 1029920 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679419 679419 0 0.0
(read/write) 172028 172028 0 0.0
.bss 81140 81140 0 0.0
.data 3380 3380 0 0.0
.rodata 89995 89995 0 0.0
.text 589112 589112 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643683 643683 0 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79131 79131 0 0.0
.text 564232 564232 0 0.0
lock-ftd LP_CC2652R7 (read only) 676967 676967 0 0.0
(read/write) 172040 172040 0 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77423 77423 0 0.0
.text 599064 599064 0 0.0
lock-mtd LP_CC2652R7 (read only) 661755 661755 0 0.0
(read/write) 182516 182516 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 103507 0 0.0
.text 557768 557768 0 0.0
pump-app LP_CC2652R7 (read only) 689879 689879 0 0.0
(read/write) 159864 159864 0 0.0
.bss 78756 78756 0 0.0
.data 3296 3296 0 0.0
.rodata 90943 90943 0 0.0
.text 598452 598452 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673787 673787 0 0.0
(read/write) 176060 176060 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86491 86491 0 0.0
.text 586816 586816 0 0.0
shell LP_CC2652R7 (read only) 670658 670658 0 0.0
(read/write) 183116 183116 0 0.0
.bss 83468 83468 0 0.0
.data 3376 3376 0 0.0
.rodata 86738 86738 0 0.0
.text 583604 583604 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588050 588050 0 0.0
.app_xip_area 464396 464396 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591862 591862 0 0.0
.app_xip_area 462912 462912 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551302 551302 0 0.0
.app_xip_area 433144 433144 0 0.0
.bss 60656 60656 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975916 975916 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 821556 821556 0 0.0
BRD4161A+rs911x (read/write) 1037984 1037984 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 849300 849300 0 0.0
BRD4187C (read/write) 1149016 1149016 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 983336 983336 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163424 1163424 0 0.0
.bss 158216 158216 0 0.0
.data 2020 2020 0 0.0
.text 1003168 1003168 0 0.0
window-app BRD4187C (read/write) 1141652 1141652 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 974532 974532 0 0.0
esp32 all-clusters-app c3devkit (read only) 1218828 1218828 0 0.0
(read/write) 1790858 1790858 0 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248296 248296 0 0.0
.flash.text 1218828 1218828 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1232911 1232911 0 0.0
(read/write) 564095 564099 4 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314088 314092 4 0.0
.flash.text 1227527 1227527 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662284 662284 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 564036 564036 0 0.0
light k32w0+release (read/write) 672848 672848 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 593236 593236 0 0.0
lock k32w0+release (read/write) 633820 633820 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 553428 553428 0 0.0
linux all-clusters-app debug (read only) 3111913 3111913 0 0.0
(read/write) 158504 158504 0 0.0
.bss 62464 62464 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281291 281291 0 0.0
.text 2646082 2646082 0 0.0
all-clusters-minimal-app debug (read only) 2935593 2935593 0 0.0
(read/write) 149904 149904 0 0.0
.bss 61664 61664 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280747 280747 0 0.0
.text 2473346 2473346 0 0.0
bridge-app debug (read only) 2473433 2473433 0 0.0
(read/write) 131248 131248 0 0.0
.bss 51488 51488 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 69912 69912 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 211520 211520 0 0.0
.text 2092178 2092178 0 0.0
chip-tool debug (read only) 11167177 11167177 0 0.0
(read/write) 642424 642424 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 607184 607184 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 604805 604805 0 0.0
.text 9076564 9076564 0 0.0
chip-tool-ipv6only arm64 (read only) 10580220 10580220 0 0.0
(read/write) 691528 691528 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 635992 635992 0 0.0
.dynamic 560 560 0 0.0
.got 13816 13816 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534940 534940 0 0.0
.text 8410628 8410628 0 0.0
lighting-app debug+rpc (read only) 2661761 2661761 0 0.0
(read/write) 132392 132392 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73928 73928 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227904 227904 0 0.0
.text 2257250 2257250 0 0.0
lock-app debug (read only) 2620841 2620841 0 0.0
(read/write) 127376 127376 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70856 70856 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244168 244168 0 0.0
.text 2204914 2204914 0 0.0
ota-provider-app debug (read only) 2187513 2187513 0 0.0
(read/write) 105512 105512 0 0.0
.bss 46560 46560 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51784 51784 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 195048 195048 0 0.0
.text 1852898 1852898 0 0.0
ota-requestor-app debug (read only) 2356249 2356249 0 0.0
(read/write) 113856 113856 0 0.0
.bss 49088 49088 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57128 57128 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202160 202160 0 0.0
.text 2005330 2005330 0 0.0
shell debug (read only) 2644369 2644369 0 0.0
(read/write) 142968 142968 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239538 239538 0 0.0
.text 2245266 2245266 0 0.0
thermostat-no-ble arm64 (read only) 2475244 2475244 0 0.0
(read/write) 144920 144920 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78552 78552 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149288 149288 0 0.0
.text 2065600 2065600 0 0.0
tv-app debug (read only) 3283857 3283857 0 0.0
(read/write) 262152 262152 0 0.0
.bss 170808 170808 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80392 80392 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268536 268536 0 0.0
.text 2821282 2821282 0 0.0
tv-casting-app debug (read only) 5642953 5642953 0 0.0
(read/write) 162480 162480 0 0.0
.bss 52184 52184 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101768 101768 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 359001 359001 0 0.0
.text 5006818 5006818 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463296 2463296 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1425940 1425940 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190419 1190419 0 0.0
bss 145205 145205 0 0.0
rodata 144456 144456 0 0.0
text 819642 819642 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1360682 1360682 0 0.0
bss 105144 105144 0 0.0
rodata 211552 211552 0 0.0
text 759482 759482 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136079 1136079 0 0.0
bss 144440 144440 0 0.0
rodata 120772 120772 0 0.0
text 789810 789810 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842056 842056 0 0.0
(read/write) 1748748 1748748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238008 1238008 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 371820 371820 0 0.0
.debug_info 27053821 27053821 0 0.0
.debug_line 3707074 3707074 0 0.0
.debug_loc 3621660 3621660 0 0.0
.debug_ranges 346088 346088 0 0.0
.debug_str 3449750 3449750 0 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571657 571657 0 0.0
.symtab 421984 421984 0 0.0
.text 0 0 0 0.0
1549072 1549072 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1691276 1691276 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229899 1229899 0 0.0
.debug_aranges 110216 110216 0 0.0
.debug_frame 374876 374876 0 0.0
.debug_info 26790637 26790637 0 0.0
.debug_line 3726011 3726011 0 0.0
.debug_loc 3609266 3609266 0 0.0
.debug_ranges 344704 344704 0 0.0
.debug_str 3438762 3438762 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535746 535746 0 0.0
.symtab 408416 408416 0 0.0
.text 1492328 1492328 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1609476 1609476 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064696 1064696 0 0.0
.debug_aranges 102416 102416 0 0.0
.debug_frame 345212 345212 0 0.0
.debug_info 22253312 22253312 0 0.0
.debug_line 3293344 3293344 0 0.0
.debug_loc 3307174 3307174 0 0.0
.debug_ranges 308840 308840 0 0.0
.debug_str 3244348 3244348 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472071 472071 0 0.0
.symtab 376784 376784 0 0.0
.text 1418720 1418720 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1643428 1643428 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066628 1066628 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 347008 347008 0 0.0
.debug_info 22471735 22471734 -1 -0.0
.debug_line 3293174 3293174 0 0.0
.debug_loc 3328620 3328620 0 0.0
.debug_ranges 310696 310696 0 0.0
.debug_str 3260186 3260186 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474788 474788 0 0.0
.symtab 378784 378784 0 0.0
.text 1447680 1447680 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150804 1150804 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 597904 597904 0 0.0
lock-app qpg6105+debug (read/write) 1117108 1117108 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 564204 564204 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1070860 1070860 0 0.0
bss 98856 98856 0 0.0
text 725678 725674 -4 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1010160 1010160 0 0.0
bss 98080 98080 0 0.0
text 690840 690838 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 931624 931624 0 0.0
bss 90320 90320 0 0.0
text 637460 637460 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1009592 1009592 0 0.0
bss 98380 98380 0 0.0
text 703238 703236 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945220 945212 -8 -0.0
bss 91276 91276 0 0.0
text 648718 648716 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934756 934764 8 0.0
bss 91712 91712 0 0.0
text 638144 638146 2 0.0

@woody-apple woody-apple merged commit 127deca into project-chip:master Dec 14, 2022
@bzbarsky-apple bzbarsky-apple deleted the allow-markdown-in-issue-templates branch December 14, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants