-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: Tidy up Xcode project file and header naming #24072
Darwin: Tidy up Xcode project file and header naming #24072
Conversation
ksperling-apple
commented
Dec 14, 2022
- Add missing header files to the project file and sort groups
- Align group names / paths better with the file system
- Consistently use "_Internal.h" for internal slice of a header (but only if the base header exists)
eaf1b7d
to
d06212f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wish it were clearer which are public headers and which are not, but this is definitely a step forward!
PR #24072: Size comparison from 8055d86 to d06212f Increases (5 builds for bl602, cc13x2_26x2, cyw30739, esp32, telink)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
b73b96d
to
1e8a39f
Compare
Yeah, I guess in Xcode you see that in the side bar... Maybe we could add add a header comment like |
Fast-tracking platform specific change with platform owner review. |
PR #24072: Size comparison from d072ffb to 1e8a39f Decreases (7 builds for bl702, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
- Add missing header files to the project file and sort groups - Align group names / paths better with the file system - Consistently use "_Internal.h" for internal slice of a header (but only if the base header exists)
1e8a39f
to
d491d6b
Compare
PR #24072: Size comparison from 127deca to d491d6b Increases (5 builds for cc13x2_26x2, cyw30739, esp32, telink)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|