-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pigweed roll with fixes for compilation #24064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24064: Size comparison from 64b2ca4 to 8d7413b Increases above 0.2%:
Increases (10 builds for bl702, linux, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl702, cyw30739, linux, psoc6, telink)
Full report (28 builds for bl602, bl702, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
rgoliver
approved these changes
Dec 13, 2022
PR #24064: Size comparison from 64b2ca4 to b595881 Increases above 0.2%:
Increases (6 builds for bl602, bl702, linux, nrfconnect, qpg)
Decreases (7 builds for bl702, cyw30739, linux, psoc6)
Full report (22 builds for bl602, bl702, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
andy31415
force-pushed
the
pw_roll_with_fix
branch
from
December 13, 2022 20:22
b595881
to
ac1da85
Compare
yufengwangca
approved these changes
Dec 13, 2022
PR #24064: Size comparison from 64b2ca4 to 14f4001 Increases above 0.2%:
Increases (10 builds for bl602, bl702, linux, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for bl702, cyw30739, esp32, linux, psoc6, telink)
Full report (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24060 we noticed that clang was updated from version 14 to 15 in pigweed, resulting in more strict compile errors.
This PR bumps up pigweed but also fixes compilation.