Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SetuopCodePairer] Add a comment to explain why device discovered ove… #24058

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[SetuopCodePairer] Add a comment to explain why device discovered ove… #24058

merged 1 commit into from
Dec 13, 2022

Conversation

vivien-apple
Copy link
Contributor

…r BLE are using emplace_front and not emplace_back

Problem

The fact that ble discovered device in SetupCodePairer.cpp uses emplace_front and not emplace_back can be confusing and makes people things it is a bug. This PR just add a comment above to make it clearer that it is expected.

@vivien-apple
[SetuopCodePairer] Add a comment to explain why device discovered ove…
94bb452 
…r BLE are using emplace_front and not emplace_back
@vivien-apple vivien-apple self-assigned this Dec 13, 2022
@github-actions
Copy link

github-actions bot commented Dec 13, 2022 •
edited
Loading

PR #24058: Size comparison from 9e371e6 to 94bb452

Increases (9 builds for bl602, bl702, psoc6, telink)
platform target config section 9e371e6 94bb452 change % change
bl602 lighting-app bl602 .text 1038516 1038520 4 0.0
bl702 lighting-app bl702+rpc .debug_info 43491832 43491834 2 0.0
.text 1030180 1030184 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22489716 22489718 2 0.0
telink all-clusters-app tlsr9518adk80d text 739534 739536 2 0.0
all-clusters-minimal-app tlsr9518adk80d text 704740 704742 2 0.0
light-switch-app tlsr9518adk80d text 651348 651350 2 0.0
lighting-app tlsr9518adk80d text 719732 719734 2 0.0
ota-requestor-app tlsr9518adk80d text 662608 662610 2 0.0
thermostat tlsr9518adk80d text 651812 651814 2 0.0
Decreases (2 builds for esp32)
platform target config section 9e371e6 94bb452 change % change
esp32 all-clusters-app c3devkit (read only) 1219178 1219174 -4 -0.0
.flash.text 1219178 1219174 -4 -0.0
m5stack (read/write) 564187 564183 -4 -0.0
.flash.rodata 314100 314096 -4 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 9e371e6 94bb452 change % change
bl602 lighting-app bl602 (read/write) 1355798 1355798 0 0.0
.bss 87057 87057 0 0.0
.data 9984 9984 0 0.0
.text 1038516 1038520 4 0.0
bl602+rpc (read/write) 1401582 1401582 0 0.0
.bss 95097 95097 0 0.0
.data 10384 10384 0 0.0
.text 1069938 1069938 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195695 1195695 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67182 67182 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1529198 1529198 0 0.0
.debug_aranges 132728 132728 0 0.0
.debug_frame 486912 486912 0 0.0
.debug_info 39199526 39199526 0 0.0
.debug_line 5149108 5149108 0 0.0
.debug_loc 3380081 3380081 0 0.0
.debug_ranges 363736 363736 0 0.0
.debug_str 3479489 3479489 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116352 116352 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568924 568924 0 0.0
.symtab 172176 172176 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956206 956206 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284187 1284187 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75198 75198 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1676612 1676612 0 0.0
.debug_aranges 140848 140848 0 0.0
.debug_frame 514328 514328 0 0.0
.debug_info 43491832 43491834 2 0.0
.debug_line 5538551 5538551 0 0.0
.debug_loc 3574716 3574716 0 0.0
.debug_ranges 387272 387272 0 0.0
.debug_str 3881758 3881758 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130096 130096 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629208 629208 0 0.0
.symtab 190352 190352 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030180 1030184 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679727 679727 0 0.0
(read/write) 171800 171800 0 0.0
.bss 81220 81220 0 0.0
.data 3380 3380 0 0.0
.rodata 89999 89999 0 0.0
.text 589416 589416 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643983 643983 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79135 79135 0 0.0
.text 564528 564528 0 0.0
lock-ftd LP_CC2652R7 (read only) 677259 677259 0 0.0
(read/write) 171828 171828 0 0.0
.bss 78868 78868 0 0.0
.data 3304 3304 0 0.0
.rodata 77427 77427 0 0.0
.text 599352 599352 0 0.0
lock-mtd LP_CC2652R7 (read only) 662055 662055 0 0.0
(read/write) 182296 182296 0 0.0
.bss 74132 74132 0 0.0
.data 3304 3304 0 0.0
.rodata 103511 103511 0 0.0
.text 558064 558064 0 0.0
pump-app LP_CC2652R7 (read only) 690187 690187 0 0.0
(read/write) 159636 159636 0 0.0
.bss 78836 78836 0 0.0
.data 3296 3296 0 0.0
.rodata 90947 90947 0 0.0
.text 598756 598756 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674095 674095 0 0.0
(read/write) 175832 175832 0 0.0
.bss 78940 78940 0 0.0
.data 3292 3292 0 0.0
.rodata 86495 86495 0 0.0
.text 587120 587120 0 0.0
shell LP_CC2652R7 (read only) 670966 670966 0 0.0
(read/write) 182888 182888 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86742 86742 0 0.0
.text 583908 583908 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588406 588406 0 0.0
.app_xip_area 464672 464672 0 0.0
.bss 66192 66192 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592218 592218 0 0.0
.app_xip_area 463188 463188 0 0.0
.bss 71480 71480 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551682 551682 0 0.0
.app_xip_area 433444 433444 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976256 976256 0 0.0
.bss 152252 152252 0 0.0
.data 2168 2168 0 0.0
.text 821816 821816 0 0.0
BRD4161A+rs911x (read/write) 1038336 1038336 0 0.0
.bss 186728 186728 0 0.0
.data 2012 2012 0 0.0
.text 849576 849576 0 0.0
BRD4187C (read/write) 1149444 1149444 0 0.0
.bss 138648 138648 0 0.0
.data 2516 2516 0 0.0
.text 983684 983684 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163720 1163720 0 0.0
.bss 158296 158296 0 0.0
.data 2020 2020 0 0.0
.text 1003380 1003380 0 0.0
window-app BRD4187C (read/write) 1141960 1141960 0 0.0
.bss 140064 140064 0 0.0
.data 2540 2540 0 0.0
.text 974760 974760 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219178 1219174 -4 -0.0
(read/write) 1790954 1790954 0 0.0
.dram0.bss 76992 76992 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248312 248312 0 0.0
.flash.text 1219178 1219174 -4 -0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233359 1233359 0 0.0
(read/write) 564187 564183 -4 -0.0
.dram0.bss 82144 82144 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314100 314096 -4 -0.0
.flash.text 1227975 1227975 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662656 662656 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564328 564328 0 0.0
light k32w0+release (read/write) 673220 673220 0 0.0
.bss 74904 74904 0 0.0
.data 2060 2060 0 0.0
.text 593528 593528 0 0.0
lock k32w0+release (read/write) 634176 634176 0 0.0
.bss 75664 75664 0 0.0
.data 2080 2080 0 0.0
.text 553704 553704 0 0.0
linux all-clusters-app debug (read only) 3112353 3112353 0 0.0
(read/write) 158504 158504 0 0.0
.bss 62464 62464 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87160 87160 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281227 281227 0 0.0
.text 2646562 2646562 0 0.0
all-clusters-minimal-app debug (read only) 2936033 2936033 0 0.0
(read/write) 149936 149936 0 0.0
.bss 61664 61664 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79528 79528 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280683 280683 0 0.0
.text 2473826 2473826 0 0.0
bridge-app debug (read only) 2473841 2473841 0 0.0
(read/write) 131280 131280 0 0.0
.bss 51488 51488 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 69928 69928 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 211424 211424 0 0.0
.text 2092658 2092658 0 0.0
chip-tool debug (read only) 11249681 11249681 0 0.0
(read/write) 659992 659992 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 624760 624760 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 604933 604933 0 0.0
.text 9117444 9117444 0 0.0
chip-tool-ipv6only arm64 (read only) 10626028 10626028 0 0.0
(read/write) 708129 708129 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652416 652416 0 0.0
.dynamic 560 560 0 0.0
.got 13960 13960 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 531628 531628 0 0.0
.text 8434916 8434916 0 0.0
lighting-app debug+rpc (read only) 2662201 2662201 0 0.0
(read/write) 132424 132424 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73944 73944 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227840 227840 0 0.0
.text 2257730 2257730 0 0.0
lock-app debug (read only) 2621281 2621281 0 0.0
(read/write) 127376 127376 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70856 70856 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244104 244104 0 0.0
.text 2205394 2205394 0 0.0
ota-provider-app debug (read only) 2187921 2187921 0 0.0
(read/write) 105512 105512 0 0.0
.bss 46560 46560 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51784 51784 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 194952 194952 0 0.0
.text 1853378 1853378 0 0.0
ota-requestor-app debug (read only) 2356641 2356641 0 0.0
(read/write) 113888 113888 0 0.0
.bss 49088 49088 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57144 57144 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202064 202064 0 0.0
.text 2005794 2005794 0 0.0
shell debug (read only) 2644809 2644809 0 0.0
(read/write) 142968 142968 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78048 78048 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239474 239474 0 0.0
.text 2245746 2245746 0 0.0
thermostat-no-ble arm64 (read only) 2436132 2436132 0 0.0
(read/write) 143857 143857 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77472 77472 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145404 145404 0 0.0
.text 2046736 2046736 0 0.0
tv-app debug (read only) 3284233 3284233 0 0.0
(read/write) 262152 262152 0 0.0
.bss 170808 170808 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80400 80400 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268376 268376 0 0.0
.text 2821794 2821794 0 0.0
tv-casting-app debug (read only) 5642833 5642833 0 0.0
(read/write) 162480 162480 0 0.0
.bss 52184 52184 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101776 101776 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 358841 358841 0 0.0
.text 5006978 5006978 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463624 2463624 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1426268 1426268 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190871 1190871 0 0.0
bss 145285 145285 0 0.0
rodata 144460 144460 0 0.0
text 819958 819958 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1361070 1361070 0 0.0
bss 105224 105224 0 0.0
rodata 211556 211556 0 0.0
text 759802 759802 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136515 1136515 0 0.0
bss 144520 144520 0 0.0
rodata 120776 120776 0 0.0
text 790126 790126 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841976 841976 0 0.0
(read/write) 1749100 1749100 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188704 188704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238249 1238249 0 0.0
.debug_aranges 110928 110928 0 0.0
.debug_frame 372332 372332 0 0.0
.debug_info 27071803 27071803 0 0.0
.debug_line 3708433 3708433 0 0.0
.debug_loc 3623407 3623407 0 0.0
.debug_ranges 346376 346376 0 0.0
.debug_str 3449854 3449854 0 0.0
.heap 841976 841976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571764 571764 0 0.0
.symtab 422064 422064 0 0.0
.text 1549344 1549344 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1691628 1691628 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1230140 1230140 0 0.0
.debug_aranges 110400 110400 0 0.0
.debug_frame 375388 375388 0 0.0
.debug_info 26808620 26808620 0 0.0
.debug_line 3727370 3727370 0 0.0
.debug_loc 3611013 3611013 0 0.0
.debug_ranges 344992 344992 0 0.0
.debug_str 3438866 3438866 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535853 535853 0 0.0
.symtab 408496 408496 0 0.0
.text 1492600 1492600 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1609836 1609836 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064937 1064937 0 0.0
.debug_aranges 102600 102600 0 0.0
.debug_frame 345724 345724 0 0.0
.debug_info 22271294 22271294 0 0.0
.debug_line 3294697 3294697 0 0.0
.debug_loc 3308920 3308920 0 0.0
.debug_ranges 309128 309128 0 0.0
.debug_str 3244452 3244452 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472178 472178 0 0.0
.symtab 376864 376864 0 0.0
.text 1419000 1419000 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845904 845904 0 0.0
(read/write) 1643780 1643780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184968 184968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066869 1066869 0 0.0
.debug_aranges 102984 102984 0 0.0
.debug_frame 347520 347520 0 0.0
.debug_info 22489716 22489718 2 0.0
.debug_line 3294527 3294527 0 0.0
.debug_loc 3330367 3330367 0 0.0
.debug_ranges 310984 310984 0 0.0
.debug_str 3260290 3260290 0 0.0
.heap 845904 845904 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474895 474895 0 0.0
.symtab 378864 378864 0 0.0
.text 1447952 1447952 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151088 1151088 0 0.0
.bss 100428 100428 0 0.0
.data 840 840 0 0.0
.text 598188 598188 0 0.0
lock-app qpg6105+debug (read/write) 1117392 1117392 0 0.0
.bss 95908 95908 0 0.0
.data 836 836 0 0.0
.text 564488 564488 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1091812 1091812 0 0.0
bss 99808 99808 0 0.0
text 739534 739536 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1031184 1031184 0 0.0
bss 99032 99032 0 0.0
text 704740 704742 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952608 952608 0 0.0
bss 91272 91272 0 0.0
text 651348 651350 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1034024 1034024 0 0.0
bss 100420 100420 0 0.0
text 719732 719734 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 966200 966200 0 0.0
bss 92228 92228 0 0.0
text 662608 662610 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 955320 955320 0 0.0
bss 92664 92664 0 0.0
text 651812 651814 2 0.0

@vivien-apple vivien-apple merged commit 64b2ca4 into project-chip:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @andy31415 @bzbarsky-apple