-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes in tv-casting-app to allow setting custom Setup Passcodes and backgrounding the app on iOS #24046
Merged
chrisdecenzo
merged 4 commits into
project-chip:master
from
sharadb-amazon:fixes-20221212
Dec 23, 2022
Merged
Fixes in tv-casting-app to allow setting custom Setup Passcodes and backgrounding the app on iOS #24046
chrisdecenzo
merged 4 commits into
project-chip:master
from
sharadb-amazon:fixes-20221212
Dec 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdecenzo
approved these changes
Dec 12, 2022
PR #24046: Size comparison from 1dc4b23 to 5259790 Increases (3 builds for bl602, cc13x2_26x2, telink)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, k32w, telink)
Full report (28 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #24046: Size comparison from 1dc4b23 to 796f3e2 Increases (9 builds for bl602, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (5 builds for bl702, cc13x2_26x2, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cliffamzn
reviewed
Dec 12, 2022
...les/tv-casting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/CastingServerBridge.mm
Outdated
Show resolved
Hide resolved
...les/tv-casting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/CastingServerBridge.mm
Show resolved
Hide resolved
PR #24046: Size comparison from 1dc4b23 to 1b8dcc1 Increases (11 builds for bl702, cc13x2_26x2, cyw30739, esp32, psoc6)
Decreases (27 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cliffamzn
reviewed
Dec 13, 2022
...les/tv-casting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/CastingServerBridge.mm
Outdated
Show resolved
Hide resolved
cliffamzn
approved these changes
Dec 13, 2022
b7f3483
to
c28df90
Compare
PR #24046: Size comparison from 64b2ca4 to c28df90 Increases (3 builds for nrfconnect, telink)
Decreases (11 builds for bl602, bl702, esp32, psoc6, telink)
Full report (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Dec 14, 2022
…uired in CommissionableDataProviderImpl
…omes inactive/active. Also, disabling BLE
c28df90
to
d9a3815
Compare
PR #24046: Size comparison from d072ffb to d9a3815 Increases (5 builds for bl602, esp32, k32w, psoc6, telink)
Decreases (6 builds for bl702, cyw30739, esp32, nrfconnect, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Dec 23, 2022
…ackgrounding the app on iOS (project-chip#24046) * tv-casting-app: Making getDiscoveredCommissioner API synchronous * iOS MatterTvCastingBridge: Generate spake2pSalt (and verifier) if required in CommissionableDataProviderImpl * tv-casting-app/darwin: Stopping/restarting Matter server when app becomes inactive/active. Also, disabling BLE * Addressing cliffamzn@'s feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24045 and #24048
Problem
Change summary
Testing
Tested with the iOS tv-casting-app (by setting a non-test setup PIN in the code and putting screen to sleep/waking it up) and the Linux tv-app.