-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dispatch queues in the Darwin framework more consistently. #24005
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:matter-queue-uniformity
Dec 12, 2022
Merged
Create dispatch queues in the Darwin framework more consistently. #24005
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:matter-queue-uniformity
Dec 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bzbarsky-apple
commented
Dec 9, 2022
- Use a common prefix for all the queue labels ("com.csa-iot.matter.framework").
- Use DISPATCH_QUEUE_SERIAL_WITH_AUTORELEASE_POOL for all the queues.
- Use a common suffix ("workqueue") for all work queues.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
rgoliver and
robszewczyk
December 9, 2022 18:35
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
December 9, 2022 18:35
jtung-apple
reviewed
Dec 9, 2022
jtung-apple
reviewed
Dec 9, 2022
src/darwin/Framework/CHIP/MTRPersistentStorageDelegateBridge.mm
Outdated
Show resolved
Hide resolved
bzbarsky-apple
force-pushed
the
matter-queue-uniformity
branch
from
December 9, 2022 18:48
c769196
to
7a5fed2
Compare
PR #24005: Size comparison from 0d29955 to 7a5fed2 Increases (8 builds for bl702, cyw30739, esp32, psoc6, telink)
Decreases (2 builds for bl602, psoc6)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Dec 12, 2022
* Use a common prefix for all the queue labels ("org.csa-iot.matter.framework"). * Use DISPATCH_QUEUE_SERIAL_WITH_AUTORELEASE_POOL for all the queues. * Use a common suffix ("workqueue") for all work queues.
bzbarsky-apple
force-pushed
the
matter-queue-uniformity
branch
from
December 12, 2022 17:34
7a5fed2
to
35e8d8c
Compare
PR #24005: Size comparison from c2b07cb to 35e8d8c Increases (2 builds for cc13x2_26x2, psoc6)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.