-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] MTRDevice should retry subscription when getSessionForNode fails #23981
Merged
bzbarsky-apple
merged 5 commits into
project-chip:master
from
jtung-apple:issue-23978-mtrdevice-retry-subscription
Dec 9, 2022
Merged
[Darwin] MTRDevice should retry subscription when getSessionForNode fails #23981
bzbarsky-apple
merged 5 commits into
project-chip:master
from
jtung-apple:issue-23978-mtrdevice-retry-subscription
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtung-apple
force-pushed
the
issue-23978-mtrdevice-retry-subscription
branch
from
December 8, 2022 21:09
ff0a703
to
e6795eb
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt and
mspang
December 8, 2022 21:09
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
December 8, 2022 21:09
PR #23981: Size comparison from dcf7061 to e6795eb Increases (8 builds for cc13x2_26x2, nrfconnect, qpg, telink)
Decreases (4 builds for bl602, cc13x2_26x2)
Full report (28 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 8, 2022
Fast-tracking platform-specific change with platform owner review. |
andy31415
approved these changes
Dec 8, 2022
PR #23981: Size comparison from dcf7061 to 926bbae Increases (16 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for cc13x2_26x2, esp32)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23981: Size comparison from dcf7061 to 75a9236 Increases (13 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for bl602, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23978
Also fixes #23975
Changes details:
getSessionForNode
fails inMTRDevice _setupSubscription
, instead of only signaling error, also signal reset, which means "the subscription has gone away". And as long as a delegate object exists, that means a subscription is needed, and so a retry would be scheduled with exponential back off.