-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code to enable dmalloc & disable it #23977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently dmalloc is disabled because of a stray print from GN combined with a strict comparison of GN's output in configuring this checker. This caused tests to timeout and fail in a previous attempt to remove the print in project-chip#23687. This checker is extremely expensive, especially for tests with more allocations. For one test, it increases the cost from 1 second to 1 hour: % time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 3325.35s user 0.05s system 99% cpu 55:25.65 total % unset DMALLOC_OPTIONS % time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 1.24s user 0.01s system 99% cpu 1.249 total This is much too costly to be enabled for all unit tests in presubmit, so disable it. Other tools such as ASAN have much lower overhead.
kpschoedel
approved these changes
Dec 8, 2022
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov and
lpbeliveau-silabs
December 8, 2022 17:47
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 8, 2022 17:47
PR #23977: Size comparison from 48de603 to 4fe006f Increases (6 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (6 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Dec 8, 2022
arkq
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dmalloc is disabled because of a stray print from GN combined with a strict comparison of GN's output in configuring this checker. This caused tests to timeout and fail in a previous attempt to remove the print in #23687.
This checker is extremely expensive, especially for tests with more allocations. For one test, it increases the cost from 1 second to 1 hour:
This is much too costly to be enabled for all unit tests in presubmit, so disable it. Other tools such as ASAN have much lower overhead.