-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce basic UDP packet filtering scheme #23957
Merged
andy31415
merged 2 commits into
project-chip:master
from
tcarmelveilleux:add-packet-filter-udp3
Dec 7, 2022
Merged
Introduce basic UDP packet filtering scheme #23957
andy31415
merged 2 commits into
project-chip:master
from
tcarmelveilleux:add-packet-filter-udp3
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Embedded class devices on Wi-Fi networks can see large number of mDNS packets from normal network. If these arrive while device is processing CASE/PASE or any other long running system activity, the amount of queuing can overrun the packet buffer pools or event queues, which can cause very bad outcomes. - Filtering of packets can always be done by a product deep in its network stack. However, allowing some level of basic filtering for UDP packets (that cover most of the traffic that could be problematic and need queuing) for at least lwIP devices allows sharing code for filters that may be smarter. Follow-up PR will show an example hook-up to ESP32 Issue project-chip#23258 Issue project-chip#23180 This PR: - Adds generic EndpointQueueFilter.h, which is portable/testable on its own. - Adds hook-ups to UDPEndPointImplLwIP to run an EndpointQueueFilter on incoming packets Testing done: - Full unit test suite for the filtering framework and basic filter.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt and
mspang
December 7, 2022 15:35
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
December 7, 2022 15:35
andy31415
reviewed
Dec 7, 2022
andy31415
reviewed
Dec 7, 2022
andy31415
approved these changes
Dec 7, 2022
msandstedt
reviewed
Dec 7, 2022
msandstedt
reviewed
Dec 7, 2022
msandstedt
reviewed
Dec 7, 2022
msandstedt
reviewed
Dec 7, 2022
msandstedt
reviewed
Dec 7, 2022
msandstedt
reviewed
Dec 7, 2022
msandstedt
reviewed
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some feedback on some comments. But this looks great to me.
Thank you!
msandstedt
approved these changes
Dec 7, 2022
PR #23957: Size comparison from cd785e7 to 018af1d Increases (21 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, psoc6, telink)
Decreases (16 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up PR will show an example hook-up to ESP32
Issue #23258
Issue #23180
Changes in this PR
Testing done