Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++20-incompatible instances of aggregate initialization #23911

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fix C++20-incompatible instances of aggregate initialization #23911

merged 1 commit into from
Dec 5, 2022

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Dec 5, 2022

In C++20, types that declare or delete any constructors are no longer aggregates, breaking compilation of many existing uses of aggregate initialization.

Fix this for EmberBindingTableEntry by removing the explicitly defaulted constructor.

@mspang
Fix C++20-incompatible instances of aggregate initialization
b078bd4 
In C++20, types that declare or delete any constructors are no longer
aggregates, breaking compilation of many existing uses of aggregate
initialization.

Fix this for EmberBindingTableEntry by removing the explicitly defaulted
constructor.
@github-actions github-actions bot added the app label Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

PR #23911: Size comparison from c988a2c to b078bd4

Increases (12 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, psoc6, qpg)
platform target config section c988a2c b078bd4 change % change
bl602 lighting-app bl602 .text 1037740 1037742 2 0.0
bl702 lighting-app bl702 (read/write) 1195423 1195439 16 0.0
.debug_abbrev 1529079 1529099 20 0.0
.debug_info 39222054 39222057 3 0.0
.debug_line 5145243 5145245 2 0.0
.debug_loc 3378731 3378732 1 0.0
.text 955982 955986 4 0.0
bl702+rpc .debug_abbrev 1677193 1677213 20 0.0
.debug_info 43520366 43520367 1 0.0
.debug_line 5536258 5536260 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679451 679459 8 0.0
.text 589176 589184 8 0.0
shell LP_CC2652R7 (read/write) 183176 183184 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1163272 1163288 16 0.0
.text 1002936 1002952 16 0.0
esp32 all-clusters-app m5stack (read/write) 564159 564163 4 0.0
.flash.rodata 314072 314076 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_line 3706961 3706962 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_line 3725898 3725899 1 0.0
light cy8ckit_062s2_43012 .debug_line 3293220 3293223 3 0.0
.debug_loc 3306144 3306158 14 0.0
lock cy8ckit_062s2_43012 .debug_info 22486333 22486336 3 0.0
.debug_line 3292970 3292973 3 0.0
.debug_loc 3327542 3327556 14 0.0
qpg lighting-app qpg6105+debug (read/write) 1150924 1150932 8 0.0
.text 598024 598032 8 0.0
Decreases (6 builds for cc13x2_26x2, cyw30739, k32w, psoc6)
platform target config section c988a2c b078bd4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 172076 172068 -8 -0.0
shell LP_CC2652R7 (read only) 670670 670662 -8 -0.0
.text 583644 583636 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588406 588398 -8 -0.0
.app_xip_area 464664 464656 -8 -0.0
k32w contact k32w0+release (read/write) 662516 662500 -16 -0.0
.text 564188 564172 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27069315 27069254 -61 -0.0
.debug_loc 3620687 3620645 -42 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26806104 26806041 -63 -0.0
.debug_loc 3608293 3608251 -42 -0.0
Full report (44 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
platform target config section c988a2c b078bd4 change % change
bl602 lighting-app bl602 (read/write) 1354990 1354990 0 0.0
.bss 87057 87057 0 0.0
.data 9984 9984 0 0.0
.text 1037740 1037742 2 0.0
bl602+rpc (read/write) 1400766 1400766 0 0.0
.bss 95097 95097 0 0.0
.data 10384 10384 0 0.0
.text 1069160 1069160 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195423 1195439 16 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1529079 1529099 20 0.0
.debug_aranges 132680 132680 0 0.0
.debug_frame 486784 486784 0 0.0
.debug_info 39222054 39222057 3 0.0
.debug_line 5145243 5145245 2 0.0
.debug_loc 3378731 3378732 1 0.0
.debug_ranges 363712 363712 0 0.0
.debug_str 3479113 3479113 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116320 116320 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568701 568701 0 0.0
.symtab 172096 172096 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955982 955986 4 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283867 1283867 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75198 75198 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1677193 1677213 20 0.0
.debug_aranges 140824 140824 0 0.0
.debug_frame 514256 514256 0 0.0
.debug_info 43520366 43520367 1 0.0
.debug_line 5536258 5536260 2 0.0
.debug_loc 3573846 3573846 0 0.0
.debug_ranges 387280 387280 0 0.0
.debug_str 3881511 3881511 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130032 130032 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628923 628923 0 0.0
.symtab 190272 190272 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029916 1029916 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679451 679459 8 0.0
(read/write) 172076 172068 -8 -0.0
.bss 81220 81220 0 0.0
.data 3380 3380 0 0.0
.rodata 89963 89963 0 0.0
.text 589176 589184 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643715 643715 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79099 79099 0 0.0
.text 564296 564296 0 0.0
lock-ftd LP_CC2652R7 (read only) 677079 677079 0 0.0
(read/write) 172016 172016 0 0.0
.bss 78876 78876 0 0.0
.data 3304 3304 0 0.0
.rodata 77391 77391 0 0.0
.text 599208 599208 0 0.0
lock-mtd LP_CC2652R7 (read only) 661787 661787 0 0.0
(read/write) 182564 182564 0 0.0
.bss 74132 74132 0 0.0
.data 3304 3304 0 0.0
.rodata 103475 103475 0 0.0
.text 557832 557832 0 0.0
pump-app LP_CC2652R7 (read only) 690007 690007 0 0.0
(read/write) 159824 159824 0 0.0
.bss 78844 78844 0 0.0
.data 3296 3296 0 0.0
.rodata 90911 90911 0 0.0
.text 598612 598612 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673907 673907 0 0.0
(read/write) 176028 176028 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86459 86459 0 0.0
.text 586968 586968 0 0.0
shell LP_CC2652R7 (read only) 670670 670662 -8 -0.0
(read/write) 183176 183184 8 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86710 86710 0 0.0
.text 583644 583636 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588406 588398 -8 -0.0
.app_xip_area 464664 464656 -8 -0.0
.bss 66200 66200 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592106 592106 0 0.0
.app_xip_area 463068 463068 0 0.0
.bss 71488 71488 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551506 551506 0 0.0
.app_xip_area 433268 433268 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976116 976116 0 0.0
.bss 152252 152252 0 0.0
.data 2168 2168 0 0.0
.text 821676 821676 0 0.0
BRD4161A+rs911x (read/write) 1037616 1037616 0 0.0
.bss 186728 186728 0 0.0
.data 2012 2012 0 0.0
.text 848856 848856 0 0.0
BRD4187C (read/write) 1149188 1149188 0 0.0
.bss 138648 138648 0 0.0
.data 2516 2516 0 0.0
.text 983428 983428 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163272 1163288 16 0.0
.bss 158296 158296 0 0.0
.data 2020 2020 0 0.0
.text 1002936 1002952 16 0.0
window-app BRD4187C (read/write) 1141720 1141720 0 0.0
.bss 140064 140064 0 0.0
.data 2540 2540 0 0.0
.text 974520 974520 0 0.0
esp32 all-clusters-app c3devkit (read only) 1218692 1218692 0 0.0
(read/write) 1790922 1790922 0 0.0
.dram0.bss 76984 76984 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248280 248280 0 0.0
.flash.text 1218692 1218692 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1232851 1232851 0 0.0
(read/write) 564159 564163 4 0.0
.dram0.bss 82144 82144 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314072 314076 4 0.0
.flash.text 1227467 1227467 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662516 662500 -16 -0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564188 564172 -16 -0.0
light k32w0+release (read/write) 673080 673080 0 0.0
.bss 74904 74904 0 0.0
.data 2060 2060 0 0.0
.text 593388 593388 0 0.0
lock k32w0+release (read/write) 634036 634036 0 0.0
.bss 75664 75664 0 0.0
.data 2080 2080 0 0.0
.text 553564 553564 0 0.0
linux all-clusters-app debug (read only) 3111257 3111257 0 0.0
(read/write) 158472 158472 0 0.0
.bss 62432 62432 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281227 281227 0 0.0
.text 2645538 2645538 0 0.0
all-clusters-minimal-app debug (read only) 2934937 2934937 0 0.0
(read/write) 149872 149872 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280683 280683 0 0.0
.text 2472802 2472802 0 0.0
bridge-app debug (read only) 2427521 2427521 0 0.0
(read/write) 129576 129576 0 0.0
.bss 50976 50976 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210848 210848 0 0.0
.text 2049314 2049314 0 0.0
chip-tool debug (read only) 11239177 11239177 0 0.0
(read/write) 659960 659960 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 624736 624736 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 602085 602085 0 0.0
.text 9109860 9109860 0 0.0
chip-tool-ipv6only arm64 (read only) 10613308 10613308 0 0.0
(read/write) 708097 708097 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652392 652392 0 0.0
.dynamic 560 560 0 0.0
.got 13960 13960 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 528844 528844 0 0.0
.text 8425044 8425044 0 0.0
lighting-app debug+rpc (read only) 2661105 2661105 0 0.0
(read/write) 132328 132328 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73896 73896 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227840 227840 0 0.0
.text 2256706 2256706 0 0.0
lock-app debug (read only) 2620153 2620153 0 0.0
(read/write) 127344 127344 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244104 244104 0 0.0
.text 2204338 2204338 0 0.0
ota-provider-app debug (read only) 2186825 2186825 0 0.0
(read/write) 105480 105480 0 0.0
.bss 46528 46528 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51768 51768 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 194952 194952 0 0.0
.text 1852354 1852354 0 0.0
ota-requestor-app debug (read only) 2355545 2355545 0 0.0
(read/write) 113824 113824 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57128 57128 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202064 202064 0 0.0
.text 2004770 2004770 0 0.0
shell debug (read only) 2643713 2643713 0 0.0
(read/write) 142936 142936 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239474 239474 0 0.0
.text 2244722 2244722 0 0.0
thermostat-no-ble arm64 (read only) 2422028 2422028 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145092 145092 0 0.0
.text 2033216 2033216 0 0.0
tv-app debug (read only) 3283057 3283057 0 0.0
(read/write) 262120 262120 0 0.0
.bss 170776 170776 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268376 268376 0 0.0
.text 2820690 2820690 0 0.0
tv-casting-app debug (read only) 5633801 5633801 0 0.0
(read/write) 162384 162384 0 0.0
.bss 52088 52088 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101760 101760 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 356217 356217 0 0.0
.text 5000642 5000642 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463328 2463328 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1425972 1425972 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841976 841976 0 0.0
(read/write) 1748412 1748412 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188704 188704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238033 1238033 0 0.0
.debug_aranges 110904 110904 0 0.0
.debug_frame 372244 372244 0 0.0
.debug_info 27069315 27069254 -61 -0.0
.debug_line 3706961 3706962 1 0.0
.debug_loc 3620687 3620645 -42 -0.0
.debug_ranges 345768 345768 0 0.0
.debug_str 3448037 3448037 0 0.0
.heap 841976 841976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571557 571557 0 0.0
.symtab 421952 421952 0 0.0
.text 0 0 0 0.0
1548656 1548656 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690940 1690940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229924 1229924 0 0.0
.debug_aranges 110376 110376 0 0.0
.debug_frame 375300 375300 0 0.0
.debug_info 26806104 26806041 -63 -0.0
.debug_line 3725898 3725899 1 0.0
.debug_loc 3608293 3608251 -42 -0.0
.debug_ranges 344384 344384 0 0.0
.debug_str 3437049 3437049 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535646 535646 0 0.0
.symtab 408384 408384 0 0.0
.text 1491912 1491912 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1609132 1609132 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064721 1064721 0 0.0
.debug_aranges 102576 102576 0 0.0
.debug_frame 345636 345636 0 0.0
.debug_info 22268169 22268169 0 0.0
.debug_line 3293220 3293223 3 0.0
.debug_loc 3306144 3306158 14 0.0
.debug_ranges 308520 308520 0 0.0
.debug_str 3242635 3242635 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471971 471971 0 0.0
.symtab 376752 376752 0 0.0
.text 1418296 1418296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845904 845904 0 0.0
(read/write) 1642572 1642572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184968 184968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066637 1066637 0 0.0
.debug_aranges 102960 102960 0 0.0
.debug_frame 347432 347432 0 0.0
.debug_info 22486333 22486336 3 0.0
.debug_line 3292970 3292973 3 0.0
.debug_loc 3327542 3327556 14 0.0
.debug_ranges 310376 310376 0 0.0
.debug_str 3258478 3258478 0 0.0
.heap 845904 845904 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473633 473633 0 0.0
.symtab 378352 378352 0 0.0
.text 1446744 1446744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150924 1150932 8 0.0
.bss 97620 97620 0 0.0
.data 840 840 0 0.0
.text 598024 598032 8 0.0
lock-app qpg6105+debug (read/write) 1116740 1116740 0 0.0
.bss 93092 93092 0 0.0
.data 836 836 0 0.0
.text 563836 563836 0 0.0

@yufengwangca yufengwangca merged commit 0b8ecc8 into project-chip:master Dec 5, 2022
@mspang mspang deleted the for-chip/aggregate-init branch December 6, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mspang @andy31415 @msandstedt @yufengwangca