-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IC-Device] Add Accessor class for ClientMonitoring Cluster #23909
Merged
jmartinez-silabs
merged 10 commits into
project-chip:master
from
mkardous-silabs:feature/ic-accessors
Dec 14, 2022
Merged
[IC-Device] Add Accessor class for ClientMonitoring Cluster #23909
jmartinez-silabs
merged 10 commits into
project-chip:master
from
mkardous-silabs:feature/ic-accessors
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
December 5, 2022 16:57
PR #23909: Size comparison from c988a2c to f27b329 Increases (11 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, psoc6, qpg)
Decreases (4 builds for cc13x2_26x2, psoc6)
Full report (44 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
|
src/app/clusters/client-monitoring-server/client-monitoring-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/client-monitoring-server/client-monitoring-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/client-monitoring-server/client-monitoring-server.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <[email protected]>
pullapprove
bot
requested review from
ksperling-apple
and removed request for
isiu-apple
December 12, 2022 14:05
mkardous-silabs
force-pushed
the
feature/ic-accessors
branch
from
December 12, 2022 14:46
1c64358
to
9858352
Compare
PR #23909: Size comparison from 71da650 to 9858352 Increases (4 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
requested review from
tcarmelveilleux,
andy31415 and
bzbarsky-apple
December 12, 2022 16:06
jmeg-sfy
reviewed
Dec 13, 2022
jmeg-sfy
reviewed
Dec 13, 2022
jmeg-sfy
approved these changes
Dec 13, 2022
src/app/clusters/client-monitoring-server/client-monitoring-server.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
src/app/clusters/client-monitoring-server/client-monitoring-server.cpp
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests