-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add / Migrate Missing Unit Tests for Library Error String Facilities #239
Merged
woody-apple
merged 3 commits into
project-chip:master
from
gerickson:user/gerickson/github-issue-227
Apr 6, 2020
Merged
Add / Migrate Missing Unit Tests for Library Error String Facilities #239
woody-apple
merged 3 commits into
project-chip:master
from
gerickson:user/gerickson/github-issue-227
Apr 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring facilities.
gerickson
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
tpmanley and
woody-apple
as code owners
April 3, 2020 19:35
@tpmanley or @BroderickCarlin, @hawk248 or @jelderton? |
woody-apple
approved these changes
Apr 3, 2020
@tpmanley or @BroderickCarlin, @hawk248 or @jelderton? |
hawk248
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
BroderickCarlin
approved these changes
Apr 6, 2020
@gerickson Needs merge conflict fix |
mkardous-silabs
referenced
this pull request
in mkardous-silabs/connectedhomeip
Nov 2, 2022
…torydata provider when an image is created without a mg24 plugged in Merge in WMN_TOOLS/matter from fix_mg24_base_image to RC_1.0.0 Squashed commit of the following: commit 9adedd9e343d5e78f7d2db4631064694d93cacba Author: Junior Martinez <[email protected]> Date: Fri Oct 28 09:39:35 2022 -0400 Update the base matter mg24 nvm3 image for the factorydata provider when an image is created without a mg24 plugged in
rerasool
pushed a commit
to SiliconLabs/matter
that referenced
this pull request
Nov 2, 2022
… for the factorydata provider when an image is created without a mg24 plugged in Merge in WMN_TOOLS/matter from fix_mg24_base_image to RC_1.0.0 Squashed commit of the following: commit 9adedd9e343d5e78f7d2db4631064694d93cacba Author: Junior Martinez <[email protected]> Date: Fri Oct 28 09:39:35 2022 -0400 Update the base matter mg24 nvm3 image for the factorydata provider when an image is created without a mg24 plugged in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The support layer library error string facility and the various other layer libraries that use it are missing their unit tests.
Summary of Changes
This adds / migrates / adapts unit tests from openweave-core.
Fixes #227