Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add / Migrate Missing Unit Tests for Library Error String Facilities #239

Merged

Conversation

gerickson
Copy link
Contributor

Problem

The support layer library error string facility and the various other layer libraries that use it are missing their unit tests.

Summary of Changes

This adds / migrates / adapts unit tests from openweave-core.

Fixes #227

@woody-apple
Copy link
Contributor

@shana-apple ?

@gerickson
Copy link
Contributor Author

@gerickson
Copy link
Contributor Author

Copy link

@hawk248 hawk248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woody-apple
Copy link
Contributor

@gerickson Needs merge conflict fix

@woody-apple woody-apple merged commit 6bf716c into project-chip:master Apr 6, 2020
mkardous-silabs referenced this pull request in mkardous-silabs/connectedhomeip Nov 2, 2022
…torydata provider when an image is created without a mg24 plugged in

Merge in WMN_TOOLS/matter from fix_mg24_base_image to RC_1.0.0

Squashed commit of the following:

commit 9adedd9e343d5e78f7d2db4631064694d93cacba
Author: Junior Martinez <[email protected]>
Date:   Fri Oct 28 09:39:35 2022 -0400

    Update the base matter mg24 nvm3 image for the factorydata provider when an image is created without a mg24 plugged in
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Nov 2, 2022
… for the factorydata provider when an image is created without a mg24 plugged in

Merge in WMN_TOOLS/matter from fix_mg24_base_image to RC_1.0.0

Squashed commit of the following:

commit 9adedd9e343d5e78f7d2db4631064694d93cacba
Author: Junior Martinez <[email protected]>
Date:   Fri Oct 28 09:39:35 2022 -0400

    Update the base matter mg24 nvm3 image for the factorydata provider when an image is created without a mg24 plugged in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add / Migrate Missing Unit Tests for Support Layer Library Error String Facility
4 participants