-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsontlv] TlvToJson returns null for empty array instead of an empty … #23885
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:TlvToJson_NullEmptyArray
Dec 7, 2022
Merged
[jsontlv] TlvToJson returns null for empty array instead of an empty … #23885
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:TlvToJson_NullEmptyArray
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
December 2, 2022 21:25
pullapprove
bot
requested review from
msandstedt,
mspang,
rgoliver,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 2, 2022 21:25
andy31415
reviewed
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vivien-apple do we have unit tests for these things? TLVJson sounds like something that should be stand-alone unit testable.
PR #23885: Size comparison from 5529d74 to 00343e6 Increases (4 builds for cyw30739, esp32, nrfconnect, qpg)
Decreases (6 builds for bl602, bl702, psoc6, telink)
Full report (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
TlvToJson_NullEmptyArray
branch
from
December 5, 2022 10:00
00343e6
to
74d4cc6
Compare
PR #23885: Size comparison from 9c0ca13 to 74d4cc6 Increases (8 builds for bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (7 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…array
Problem
When an array is empty but not null (because this is not a nullable field for example),
TlvToJson
converter returnsnull
instead of an empty array.