-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Format the sw version string with some git repo info #23877
[Silabs] Format the sw version string with some git repo info #23877
Conversation
PR #23877: Size comparison from a307034 to c2bd61b Increases (12 builds for cc13x2_26x2, efr32, psoc6, qpg, telink)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, linux, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General GN build system requirement: do not use exec_script.
Beyond that, having a moving build version seems not ideal as it creates potentially a lot of recompilation when relevant input files do not seem to change.
I would note we obviously use exec_script in finding pkg_config ... however we are trying to reduce/remove whenever possible. Feedback I had from other heavy GN users was that in time exec_script was using a whitelist and is generally banned. |
c2bd61b
to
7451ac7
Compare
PR #23877: Size comparison from ac563e0 to 409c6a8 Increases (7 builds for bl602, cc13x2_26x2, psoc6, telink)
Decreases (8 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, qpg, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…IP_DEVICE_CONFIG_DEVICE_SOFTWARE_VERSION_STRING
… scripts) pass it in a gn arg and set to a define
e6fbbd2
to
6390d13
Compare
PR #23877: Size comparison from f8f4f1e to 6390d13 Increases (7 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (11 builds for bl702, cc13x2_26x2, linux, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…version as using the git formatted version will change for every commit
PR #23877: Size comparison from f8f4f1e to 2fe64d0 Increases (13 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, psoc6)
Decreases (12 builds for bl702, cc13x2_26x2, efr32, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Created a python script to fetch some information on the current git repo.
The script is used by gn in an exec_script to format a software version string based on the branch, commit SHA and state.
The formatted string is set to the #define
CHIP_DEVICE_CONFIG_DEVICE_SOFTWARE_VERSION_STRING
UPDATE :
The version formatting is now done pre-compile time by the build script and passed down to gn with and arg.
resulting Software string format:
v1.0-<branch_name>-<ShortCommitSha>[-dirty]
applied to both EFR32 platform and SiWx917