-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up cert bins docker script. #23874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
December 2, 2022 14:38
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 2, 2022 14:38
tcarmelveilleux
approved these changes
Dec 2, 2022
PR #23874: Size comparison from f9d9457 to 01fde1f Increases (4 builds for bl602, bl702, nrfconnect, qpg)
Decreases (2 builds for bl602, bl702)
Full report (13 builds for bl602, bl702, k32w, mbed, nrfconnect, qpg)
|
…parately. Checkout and bootstrap is slow.
PR #23874: Size comparison from f9d9457 to 6a01bc9 Increases (2 builds for nrfconnect, qpg)
Decreases (5 builds for bl602, bl702, qpg)
Full report (10 builds for bl602, bl702, mbed, nrfconnect, qpg)
|
andy31415
changed the title
Run cert bins compilation as a single run to preserve build environment
Fix up cert bins docker script.
Dec 2, 2022
Fast track: locally verified, CI cannot validate this anyway. |
PR #23874: Size comparison from f9d9457 to 2f7bf9f Increases (6 builds for esp32, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl602, bl702, efr32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23869
This updates the chip-cert-bins to be compilable again. Updates include:
activate.sh
to build local itemsall-clusters-minimal-app
from the build since the build targets seem buggy and minimal app is in fact NOT being built