-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print onboarding codes in esp32 ota-requestor/provider apps. #23863
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:print-qr-codes-esp32-ota
Dec 2, 2022
Merged
Print onboarding codes in esp32 ota-requestor/provider apps. #23863
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:print-qr-codes-esp32-ota
Dec 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not printing them now, which makes it hard to commission them.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
lazarkov
December 1, 2022 21:28
pullapprove
bot
requested review from
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs and
vivien-apple
December 1, 2022 21:28
pullapprove
bot
requested review from
woody-apple,
xylophone21 and
yunhanw-google
December 1, 2022 21:28
PR #23863: Size comparison from 144ec94 to 77a5111 Increases (8 builds for bl602, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, cc13x2_26x2, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
Damian-Nordic
approved these changes
Dec 2, 2022
andy31415
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not printing them now, which makes it hard to commission them.