Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove write-only variables. #23860

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Remove write-only variables. #23860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/app/MessageDef/AttributeStatusIBs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ AttributeStatusIBs::Builder & AttributeStatusIBs::Builder::EndOfAttributeStatuse
#if CHIP_CONFIG_IM_PRETTY_PRINT
CHIP_ERROR AttributeStatusIBs::Parser::PrettyPrint() const
{
CHIP_ERROR err = CHIP_NO_ERROR;
size_t NumAttributeStatus = 0;
CHIP_ERROR err = CHIP_NO_ERROR;
TLV::TLVReader reader;

PRETTY_PRINT("AttributeStatusIBs =");
Expand All @@ -68,8 +67,6 @@ CHIP_ERROR AttributeStatusIBs::Parser::PrettyPrint() const
ReturnErrorOnFailure(status.PrettyPrint());
PRETTY_PRINT_DECDEPTH();
}

++NumAttributeStatus;
}

PRETTY_PRINT("],");
Expand Down
3 changes: 0 additions & 3 deletions src/app/MessageDef/EventPathIBs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ namespace app {
CHIP_ERROR EventPathIBs::Parser::PrettyPrint() const
{
CHIP_ERROR err = CHIP_NO_ERROR;
size_t NumPath = 0;
TLV::TLVReader reader;

PRETTY_PRINT("EventPathIBs =");
Expand All @@ -54,8 +53,6 @@ CHIP_ERROR EventPathIBs::Parser::PrettyPrint() const
ReturnErrorOnFailure(path.PrettyPrint());
PRETTY_PRINT_DECDEPTH();
}

++NumPath;
}

PRETTY_PRINT("],");
Expand Down
3 changes: 0 additions & 3 deletions src/app/clusters/groups-server/groups-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ struct GroupMembershipResponse
{
GroupDataProvider::GroupEndpoint mapping;
size_t requestedCount = 0;
size_t matchCount = 0;
ReturnErrorOnFailure(mCommandData.groupList.ComputeSize(&requestedCount));

if (0 == requestedCount)
Expand All @@ -223,7 +222,6 @@ struct GroupMembershipResponse
if (mapping.endpoint_id == mEndpoint)
{
ReturnErrorOnFailure(app::DataModel::Encode(writer, TLV::AnonymousTag(), mapping.group_id));
matchCount++;
ChipLogDetail(Zcl, " 0x%02x", mapping.group_id);
}
}
Expand All @@ -238,7 +236,6 @@ struct GroupMembershipResponse
if (mapping.endpoint_id == mEndpoint && mapping.group_id == iter.GetValue())
{
ReturnErrorOnFailure(app::DataModel::Encode(writer, TLV::AnonymousTag(), mapping.group_id));
matchCount++;
ChipLogDetail(Zcl, " 0x%02x", mapping.group_id);
break;
}
Expand Down