Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we don't use the Matter dispatch queue when it's not running. #23859

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Make sure we don't use the Matter dispatch queue when it's not running. #23859

merged 1 commit into from
Dec 1, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

We've had issues where things get queued to the Matter dispatch queue while it's not running, and then when we start it up again those things run too early in startup and break in interesting ways.

The fix is to make sure we only queue things to the Matter dispatch queue when they're associated with a currently-running controller.

Fixes #22847

@bzbarsky-apple
Make sure we don't use the Matter dispatch queue when it's not running.
434eb4e 
We've had issues where things get queued to the Matter dispatch queue while it's
not running, and then when we start it up again those things run too early in
startup and break in interesting ways.

The fix is to make sure we only queue things to the Matter dispatch queue when
they're associated with a currently-running controller.

Fixes project-chip#22847
@github-actions github-actions bot added the darwin label Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022 •
edited
Loading

PR #23859: Size comparison from 53e51d8 to 434eb4e

Increases (3 builds for bl702, efr32, nrfconnect)
platform target config section 53e51d8 434eb4e change % change
bl702 lighting-app bl702 .debug_info 39140252 39140253 1 0.0
.text 955956 955958 2 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1163272 1163288 16 0.0
.text 1002936 1002952 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 819844 819848 4 0.0
Decreases (12 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
platform target config section 53e51d8 434eb4e change % change
bl602 lighting-app bl602+rpc (read/write) 1400678 1400670 -8 -0.0
.text 1069066 1069064 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 43435830 43435829 -1 -0.0
.text 1029806 1029804 -2 -0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 643715 643707 -8 -0.0
.text 564296 564288 -8 -0.0
esp32 all-clusters-app c3devkit (read/write) 1786710 1786702 -8 -0.0
.flash.rodata 256536 256528 -8 -0.0
m5stack (read/write) 562668 562660 -8 -0.0
.flash.rodata 313648 313640 -8 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 759606 759602 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27007592 27007591 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26745235 26745234 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22438283 2243828 -1 -0.0
telink all-clusters-app tlsr9518adk80d text 650212 650210 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 792164 792156 -8 -0.0
text 555310 555308 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 806540 806532 -8 -0.0
text 566650 566648 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 53e51d8 434eb4e change % change
bl602 lighting-app bl602 (read/write) 1354982 1354982 0 0.0
.bss 87057 87057 0 0.0
.data 9984 9984 0 0.0
.text 1037734 1037734 0 0.0
bl602+rpc (read/write) 1400678 1400670 -8 -0.0
.bss 95097 95097 0 0.0
.data 10384 10384 0 0.0
.text 1069066 1069064 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195407 1195407 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1526654 1526654 0 0.0
.debug_aranges 132448 132448 0 0.0
.debug_frame 485912 485912 0 0.0
.debug_info 39140252 39140253 1 0.0
.debug_line 5139500 5139500 0 0.0
.debug_loc 3373837 3373837 0 0.0
.debug_ranges 363496 363496 0 0.0
.debug_str 3472850 3472850 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116320 116320 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568431 568431 0 0.0
.symtab 171984 171984 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955956 955958 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283755 1283755 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75198 75198 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1673840 1673840 0 0.0
.debug_aranges 140584 140584 0 0.0
.debug_frame 513348 513348 0 0.0
.debug_info 43435830 43435829 -1 -0.0
.debug_line 5529652 5529652 0 0.0
.debug_loc 3569174 3569174 0 0.0
.debug_ranges 387000 387000 0 0.0
.debug_str 3874397 3874397 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130032 130032 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628585 628585 0 0.0
.symtab 190128 190128 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029806 1029804 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679451 679451 0 0.0
(read/write) 172076 172076 0 0.0
.bss 81220 81220 0 0.0
.data 3380 3380 0 0.0
.rodata 89963 89963 0 0.0
.text 589176 589176 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643715 643707 -8 -0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79099 79099 0 0.0
.text 564296 564288 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 676991 676991 0 0.0
(read/write) 172104 172104 0 0.0
.bss 78876 78876 0 0.0
.data 3304 3304 0 0.0
.rodata 77391 77391 0 0.0
.text 599120 599120 0 0.0
lock-mtd LP_CC2652R7 (read only) 661787 661787 0 0.0
(read/write) 182564 182564 0 0.0
.bss 74132 74132 0 0.0
.data 3304 3304 0 0.0
.rodata 103475 103475 0 0.0
.text 557832 557832 0 0.0
pump-app LP_CC2652R7 (read only) 689927 689927 0 0.0
(read/write) 159904 159904 0 0.0
.bss 78844 78844 0 0.0
.data 3296 3296 0 0.0
.rodata 90911 90911 0 0.0
.text 598532 598532 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673835 673835 0 0.0
(read/write) 176100 176100 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86459 86459 0 0.0
.text 586896 586896 0 0.0
shell LP_CC2652R7 (read only) 670662 670662 0 0.0
(read/write) 183184 183184 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86710 86710 0 0.0
.text 583636 583636 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588318 588318 0 0.0
.app_xip_area 464576 464576 0 0.0
.bss 66200 66200 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592018 592018 0 0.0
.app_xip_area 462980 462980 0 0.0
.bss 71488 71488 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551506 551506 0 0.0
.app_xip_area 433268 433268 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976084 976084 0 0.0
.bss 152252 152252 0 0.0
.data 2168 2168 0 0.0
.text 821644 821644 0 0.0
BRD4161A+rs911x (read/write) 1037600 1037600 0 0.0
.bss 186728 186728 0 0.0
.data 2012 2012 0 0.0
.text 848840 848840 0 0.0
BRD4187C (read/write) 1149180 1149180 0 0.0
.bss 138648 138648 0 0.0
.data 2516 2516 0 0.0
.text 983420 983420 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163272 1163288 16 0.0
.bss 158296 158296 0 0.0
.data 2020 2020 0 0.0
.text 1002936 1002952 16 0.0
window-app BRD4187C (read/write) 1141712 1141712 0 0.0
.bss 140064 140064 0 0.0
.data 2540 2540 0 0.0
.text 974512 974512 0 0.0
esp32 all-clusters-app c3devkit (read only) 1214680 1214680 0 0.0
(read/write) 1786710 1786702 -8 -0.0
.dram0.bss 76680 76680 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256536 256528 -8 -0.0
.flash.text 1214680 1214680 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1225415 1225415 0 0.0
(read/write) 562668 562660 -8 -0.0
.dram0.bss 82056 82056 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313648 313640 -8 -0.0
.flash.text 1220031 1220031 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662500 662500 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564172 564172 0 0.0
light k32w0+release (read/write) 673080 673080 0 0.0
.bss 74904 74904 0 0.0
.data 2060 2060 0 0.0
.text 593388 593388 0 0.0
lock k32w0+release (read/write) 634036 634036 0 0.0
.bss 75664 75664 0 0.0
.data 2080 2080 0 0.0
.text 553564 553564 0 0.0
linux all-clusters-app debug (read only) 3111241 3111241 0 0.0
(read/write) 158472 158472 0 0.0
.bss 62432 62432 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281227 281227 0 0.0
.text 2645522 2645522 0 0.0
all-clusters-minimal-app debug (read only) 2934921 2934921 0 0.0
(read/write) 149872 149872 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280683 280683 0 0.0
.text 2472786 2472786 0 0.0
bridge-app debug+rpc (read only) 2427489 2427489 0 0.0
(read/write) 129576 129576 0 0.0
.bss 50976 50976 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210848 210848 0 0.0
.text 2049282 2049282 0 0.0
chip-tool debug (read only) 11141249 11141249 0 0.0
(read/write) 659616 659616 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 624352 624352 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 592997 592997 0 0.0
.text 9021812 9021812 0 0.0
chip-tool-ipv6only arm64 (read only) 10528908 10528908 0 0.0
(read/write) 707697 707697 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652008 652008 0 0.0
.dynamic 560 560 0 0.0
.got 13936 13936 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 519500 519500 0 0.0
.text 8350980 8350980 0 0.0
lighting-app debug+rpc (read only) 2660817 2660817 0 0.0
(read/write) 132328 132328 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73896 73896 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227840 227840 0 0.0
.text 2256418 2256418 0 0.0
lock-app debug (read only) 2620105 2620105 0 0.0
(read/write) 127344 127344 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244104 244104 0 0.0
.text 2204290 2204290 0 0.0
ota-provider-app debug (read only) 2412401 2412401 0 0.0
(read/write) 120872 120872 0 0.0
.bss 47904 47904 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64760 64760 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216552 216552 0 0.0
.text 2027298 2027298 0 0.0
ota-requestor-app debug (read only) 2580993 2580993 0 0.0
(read/write) 129216 129216 0 0.0
.bss 50432 50432 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223600 223600 0 0.0
.text 2179746 2179746 0 0.0
shell debug (read only) 2643681 2643681 0 0.0
(read/write) 142936 142936 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239474 239474 0 0.0
.text 2244690 2244690 0 0.0
thermostat-no-ble arm64 (read only) 2421980 2421980 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145092 145092 0 0.0
.text 2033168 2033168 0 0.0
tv-app debug (read only) 3283025 3283025 0 0.0
(read/write) 262120 262120 0 0.0
.bss 170776 170776 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268376 268376 0 0.0
.text 2820658 2820658 0 0.0
tv-casting-app debug (read only) 5623337 5623337 0 0.0
(read/write) 162048 162048 0 0.0
.bss 52088 52088 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101408 101408 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 355833 355833 0 0.0
.text 4991378 4991378 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463264 2463264 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1425908 1425908 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190747 1190747 0 0.0
bss 145285 145285 0 0.0
rodata 144448 144448 0 0.0
text 819844 819848 4 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1360874 1360874 0 0.0
bss 105224 105224 0 0.0
rodata 211552 211552 0 0.0
text 759606 759602 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136391 1136391 0 0.0
bss 144520 144520 0 0.0
rodata 120764 120764 0 0.0
text 790016 790016 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841976 841976 0 0.0
(read/write) 1748412 1748412 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188704 188704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238033 1238033 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 371612 371612 0 0.0
.debug_info 27007592 27007591 -1 -0.0
.debug_line 3704147 3704147 0 0.0
.debug_loc 3616287 3616287 0 0.0
.debug_ranges 345536 345536 0 0.0
.debug_str 3442392 3442392 0 0.0
.heap 841976 841976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571557 571557 0 0.0
.symtab 421952 421952 0 0.0
.text 1548656 1548656 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690940 1690940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229924 1229924 0 0.0
.debug_aranges 110216 110216 0 0.0
.debug_frame 374668 374668 0 0.0
.debug_info 26745235 26745234 -1 -0.0
.debug_line 3723084 3723084 0 0.0
.debug_loc 3603893 3603893 0 0.0
.debug_ranges 344152 344152 0 0.0
.debug_str 3431404 3431404 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535646 535646 0 0.0
.symtab 408384 408384 0 0.0
.text 1491912 1491912 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1609132 1609132 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064721 1064721 0 0.0
.debug_aranges 102416 102416 0 0.0
.debug_frame 345004 345004 0 0.0
.debug_info 2221980 2221980 0 0.0
.debug_line 3290408 3290408 0 0.0
.debug_loc 3301755 3301755 0 0.0
.debug_ranges 308288 308288 0 0.0
.debug_str 3236990 3236990 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471971 471971 0 0.0
.symtab 376752 376752 0 0.0
.text 1418296 1418296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845904 845904 0 0.0
(read/write) 1642572 1642572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184968 184968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066637 1066637 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346800 346800 0 0.0
.debug_info 22438283 2243828 -1 -0.0
.debug_line 3290159 3290159 0 0.0
.debug_loc 3323147 3323147 0 0.0
.debug_ranges 310144 310144 0 0.0
.debug_str 3252822 3252822 0 0.0
.heap 845904 845904 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473633 473633 0 0.0
.symtab 378352 378352 0 0.0
.text 1446744 1446744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150868 1150868 0 0.0
.bss 97620 97620 0 0.0
.data 840 840 0 0.0
.text 597968 597968 0 0.0
lock-app qpg6105+debug (read/write) 1116740 1116740 0 0.0
.bss 93092 93092 0 0.0
.data 836 836 0 0.0
.text 563836 563836 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 938984 938984 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 650212 650210 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 876952 876952 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 614166 614166 0 0.0
light-switch-app tlsr9518adk80d (read/write) 792164 792156 -8 -0.0
bss 72460 72460 0 0.0
noinit 43520 43520 0 0.0
text 555310 555308 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 876492 876492 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 625552 625552 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 806540 806532 -8 -0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 566650 566648 -2 -0.0
thermostat tlsr9518adk80d (read/write) 793344 793344 0 0.0
bss 73852 73852 0 0.0
noinit 43480 43480 0 0.0
text 554286 554286 0 0.0

@yufengwangca yufengwangca merged commit efbb120 into project-chip:master Dec 1, 2022
@bzbarsky-apple bzbarsky-apple deleted the safer-queues branch December 1, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Platform] On Darwin, stop using PlatformMgrImpl().GetWorkQueue() directly as much as possible
4 participants
@bzbarsky-apple @yufengwangca @jtung-apple @woody-apple