-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put back auto-generated comments for MTRBaseClusters. #23846
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:reinstate-comments
Dec 5, 2022
Merged
Put back auto-generated comments for MTRBaseClusters. #23846
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:reinstate-comments
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt and
mspang
November 30, 2022 23:30
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21 and
yunhanw-google
November 30, 2022 23:30
PR #23846: Size comparison from 380d403 to 8a7bd02 Increases (7 builds for bl602, bl702, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for esp32, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Dec 2, 2022
andy31415
reviewed
Dec 2, 2022
andy31415
reviewed
Dec 2, 2022
andy31415
reviewed
Dec 2, 2022
andy31415
reviewed
Dec 2, 2022
The changeset that added these initially was reverted, then when re-landing this part of the change was removed to make review easier. The changes are all comment-only.
bzbarsky-apple
force-pushed
the
reinstate-comments
branch
from
December 5, 2022 15:23
8a7bd02
to
cce6a9d
Compare
PR #23846: Size comparison from 0a765c6 to cce6a9d Increases (4 builds for bl702, cc13x2_26x2, esp32, psoc6)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
approved these changes
Dec 5, 2022
Fast-tracking platform change with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset that added these initially was reverted, then when re-landing this part of the change was removed to make review easier.
The changes are all comment-only.