-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commands support for dynamically generated clusters in dynamic-bridge-app #23840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23840: Size comparison from 66c6681 to aa05bd7 Increases (8 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, cc13x2_26x2, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23840: Size comparison from fad4f23 to 046d372 Increases (12 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2, esp32, psoc6, telink)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex and
harsha-rajendran
December 12, 2022 18:10
PR #23840: Size comparison from ffc8d97 to 0941696 Increases (10 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for bl702, cc13x2_26x2, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jan 11, 2023
examples/dynamic-bridge-app/linux/include/data-model/Attribute.h
Outdated
Show resolved
Hide resolved
scripts/py_matter_idl/matter_idl/tests/outputs/cluster_with_commands/bridge/OnOff.h
Outdated
Show resolved
Hide resolved
…ag() instead of Tag()
…ariable names for better readability
mukifera
force-pushed
the
dba-clusters-gen
branch
from
January 13, 2023 16:06
3524a23
to
581e5ea
Compare
PR #23840: Size comparison from 59b023c to 581e5ea Increases (5 builds for bl702, cc13x2_26x2, nrfconnect, qpg)
Decreases (7 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…nja template and update the relevant tests
mukifera
force-pushed
the
dba-clusters-gen
branch
from
January 13, 2023 17:14
581e5ea
to
a21b528
Compare
PR #23840: Size comparison from db57c0b to a21b528 Increases (10 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (9 builds for bl702, cc13x2_26x2, cyw30739, esp32, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…_ERROR_INVALID_ARGUMENT
andy31415
reviewed
Jan 16, 2023
andy31415
approved these changes
Jan 16, 2023
PR #23840: Size comparison from 2f0c9ab to 4496927 Increases (9 builds for bl602, cc13x2_26x2, psoc6, qpg, telink)
Decreases (4 builds for bl602, cc13x2_26x2, esp32, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…idge-app (project-chip#23840) * Add commands for bridge-generated dynamic clusters * Allow reads and writes to externally stored OnOff cluster attribute * dynamic-bridge-app: implement generic read and write callbacks for externally stored attributes * Update bridge idl tests to include external storage flags * Restyled by clang-format * Document the data buffer padding size used when reading/writing external attributes * Add better error handling for attribute read/write overrides in dynamic-bridge-app * Allow bitmap32 attribute reads for dynamic clusters in dynamic-bridge-app * Adjust indentation in BridgeClustersCpp.jinja * Change the incoming command list for generated clusters to static * Change the incoming command list for generated clusters to const * Rename incomingCommandList to mIncomingCommandList for generated clusters in dynamic-bridge-app * add a test for bridge generated cluster headers * Restyle one line if statements in dynamic-bridge-app main.cpp * dynamic-bridge-app: change buffer read logic to assume byte arrays * Restyled by clang-format * dynamic-bridge-app: move tests to the proper location * dynamic-bridge-app: undo formatting done to matter_idl tests restyled by clang-formatter * dynamic-bridge-app: change read and write functions to use AnonymousTag() instead of Tag() * dynamic-bridge-app: document unclear code and refactor function and variable names for better readability * dynamic-bridge-app: mark OnListWriteBegin and OnListWriteEnd as overrides * dynamic-bridge-app: fix error handling in WriteValueToBuffer * dynamic-bridge-app: simplify the include path in BridgeClustersCpp jinja template and update the relevant tests * dynamic-bridge-app: change CHIP_ERROR_BUFFER_TOO_SMALL errors to CHIP_ERROR_INVALID_ARGUMENT * dynamic-bridge-app: allow read operations on externally stored list attributes * Restyled by whitespace * Restyled by clang-format * dynamic-bridge-app: formatting - add whitespace between function definitions * dynamic-bridge-app: fix typo in GeneratedClusters.h Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies
dynamic-bridge-app
to: