-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Add fabric index to MTRDevice/MTRClusters logging #23818
Merged
bzbarsky-apple
merged 4 commits into
project-chip:master
from
jtung-apple:issue-23671-mtrdevice-logging-add-fabric-index
Dec 1, 2022
Merged
[Darwin] Add fabric index to MTRDevice/MTRClusters logging #23818
bzbarsky-apple
merged 4 commits into
project-chip:master
from
jtung-apple:issue-23671-mtrdevice-logging-add-fabric-index
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
November 30, 2022 02:29
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
November 30, 2022 02:29
bzbarsky-apple
approved these changes
Nov 30, 2022
PR #23818: Size comparison from 2e2ae99 to ac2872c Increases (13 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, psoc6, qpg, telink)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 30, 2022
jtung-apple
force-pushed
the
issue-23671-mtrdevice-logging-add-fabric-index
branch
from
November 30, 2022 22:49
ac2872c
to
205ae17
Compare
PR #23818: Size comparison from 380d403 to 205ae17 Increases (8 builds for bl602, cc13x2_26x2, esp32, nrfconnect, qpg)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23671
This adds fabric index to MTRDevice/MTRClusters logging, and also consolidates the MTRClusters logging to functions (to save space for strings).