-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] SiWx917 platform changes #23799
Merged
jmartinez-silabs
merged 9 commits into
project-chip:master
from
rosahay-silabs:feature/SiWx917_platform_bringup
Dec 1, 2022
Merged
[Silabs] SiWx917 platform changes #23799
jmartinez-silabs
merged 9 commits into
project-chip:master
from
rosahay-silabs:feature/SiWx917_platform_bringup
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov and
LuDuda
November 29, 2022 17:08
pullapprove
bot
added
review - pending
examples
platform
and removed
examples
platform
labels
Nov 29, 2022
PR #23799: Size comparison from 4965448 to b4e824b Increases (12 builds for bl602, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (6 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
selissia
reviewed
Nov 30, 2022
selissia
reviewed
Nov 30, 2022
selissia
approved these changes
Nov 30, 2022
PR #23799: Size comparison from 4965448 to 0684bcf Increases (5 builds for bl602, bl702, linux)
Decreases (7 builds for bl602, bl702, nrfconnect)
Full report (10 builds for bl602, bl702, linux, mbed, nrfconnect)
|
andy31415
reviewed
Nov 30, 2022
examples/platform/silabs/SiWx917/SiWx917/hal/rsi_bootup_config.c
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Nov 30, 2022
andy31415
approved these changes
Nov 30, 2022
jmartinez-silabs
requested changes
Nov 30, 2022
examples/platform/silabs/SiWx917/SiWx917/hal/rsi_hal_mcu_interrupt.c
Outdated
Show resolved
Hide resolved
examples/platform/silabs/SiWx917/SiWx917/hal/rsi_hal_mcu_timer.c
Outdated
Show resolved
Hide resolved
examples/platform/silabs/SiWx917/SiWx917/hal/rsi_hal_mcu_timer.c
Outdated
Show resolved
Hide resolved
jmartinez-silabs
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR consists of working of SiWx917 till commissioning and sending some commands. The files that were modified were as follows
Tested locally with commissioning working with SiWx917