-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set auto_envvar_prefix for click scripts to CHIP #23797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkq
force-pushed
the
auto-envvar-prefix
branch
from
November 29, 2022 15:19
4633cce
to
7ae6333
Compare
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
November 29, 2022 15:19
pullapprove
bot
requested review from
woody-apple,
xylophone21,
tecimovic,
tehampson,
turon,
vijs and
vivien-apple
November 29, 2022 15:19
PR #23797: Size comparison from e7a28bf to 7ae6333 Increases above 0.2%:
Increases (9 builds for bl602, bl702, esp32, linux, nrfconnect, psoc6, telink)
Decreases (4 builds for linux, nrfconnect, psoc6)
Full report (43 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
arkq
force-pushed
the
auto-envvar-prefix
branch
from
November 30, 2022 08:48
7ae6333
to
bff0b52
Compare
PR #23797: Size comparison from 4a8f8eb to bff0b52 Increases above 0.2%:
Increases (7 builds for cc13x2_26x2, esp32, linux, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect, psoc6, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
force-pushed
the
auto-envvar-prefix
branch
from
November 30, 2022 15:52
bff0b52
to
5180b4a
Compare
PR #23797: Size comparison from 5839cf2 to 81884dd Increases above 0.2%:
Increases (4 builds for esp32, k32w, linux, telink)
Decreases (10 builds for bl602, bl702, linux, nrfconnect, psoc6, qpg)
Full report (45 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
force-pushed
the
auto-envvar-prefix
branch
from
December 1, 2022 10:13
81884dd
to
bafaa6b
Compare
This change will allow setting default values for e.g. build_examples.py script with environment variables. Simple use case might be to enable ccache for all targets and disable timestamp logs with: export CHIP_NO_LOG_TIMESTAMPS=true export CHIP_PW_COMMAND_LAUNCHER=ccache
arkq
force-pushed
the
auto-envvar-prefix
branch
from
December 1, 2022 10:14
bafaa6b
to
fec4d70
Compare
PR #23797: Size comparison from b46af33 to fec4d70 Increases above 0.2%:
Increases (8 builds for cc13x2_26x2, linux, psoc6, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Dec 1, 2022
andy31415
reviewed
Dec 1, 2022
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Dec 3, 2022
project-chip#23797 raced with project-chip#23876 to lead to a failing job.
andy31415
pushed a commit
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This change will allow setting default values for e.g. build_examples.py script with environment variables. Simple use case might be to enable ccache for all targets and disable timestamp logs with:
Changes
CHIP_NO_LOG_TIMESTAMPS=true
in all CI workflows where build_examples.py is usedgn_build_example.sh
usage tobuild_examples.py
where appropriateTesting
CI will test that