-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code pre-generation support #23763
Merged
andy31415
merged 49 commits into
project-chip:master
from
andy31415:pregenerate_support
Nov 30, 2022
Merged
Code pre-generation support #23763
andy31415
merged 49 commits into
project-chip:master
from
andy31415:pregenerate_support
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 25, 2022 16:03
PR #23763: Size comparison from 03d9ae8 to 5ee8508 Increases (7 builds for bl702, cc13x2_26x2, k32w, qpg, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, nrfconnect, psoc6)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
… config and applies to generated sources
PR #23763: Size comparison from 03d9ae8 to cf2075c Increases (8 builds for bl702, cc13x2_26x2, k32w, psoc6, qpg)
Decreases (16 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Nov 25, 2022
tehampson
reviewed
Nov 28, 2022
PR #23763: Size comparison from 5ec87ed to 716245c Increases (7 builds for bl702, cc13x2_26x2, esp32, qpg, telink)
Decreases (16 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
config
controller
documentation
Improvements or additions to documentation
fast track
github
gn
review - pending
scripts
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use compile time code generation for some build files. This seems to not always be desirable and we would like to be able to pre-generate files:
Changes
scripts/codepregen.py
that is capable to pre-generate everything currently needed to be codegen at compile-time. Added multi-processing support to make this codegen faster.Testing:
manually tested various builds (including linux, android, dynamic-bridge, nrf, telink, mbed, esp32) to show that we can use pre-generated files.