-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modernize-redundant-void-arg to clang-tidy #23760
Merged
andy31415
merged 3 commits into
project-chip:master
from
arkq:modernize-redundant-void-arg
Nov 29, 2022
Merged
Add modernize-redundant-void-arg to clang-tidy #23760
andy31415
merged 3 commits into
project-chip:master
from
arkq:modernize-redundant-void-arg
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23760: Size comparison from 733afaa to fd03cbd Increases (6 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, telink)
Decreases (8 builds for bl702, nrfconnect, psoc6, qpg, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
github-actions
bot
added
darwin
documentation
Improvements or additions to documentation
labels
Nov 25, 2022
PR #23760: Size comparison from 733afaa to 21c0f86 Increases (10 builds for cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, telink)
Decreases (10 builds for cc13x2_26x2, cyw30739, k32w, nrfconnect, psoc6, qpg, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu and
chulspro
November 26, 2022 08:02
pullapprove
bot
requested review from
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
November 26, 2022 08:02
andy31415
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For C++ code in functions without arguments void arg is not necessary. Since Matter SDK is C++ project it seems reasonable to enforce such style with clang-format.
Changes
void
from functionsTesting
CI will test that