-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] SiWx917 folder structure skeleton in silabs folder #23750
Merged
andy31415
merged 6 commits into
project-chip:master
from
rosahay-silabs:feature/SiWx917_folder_skeleton
Nov 29, 2022
Merged
[Silabs] SiWx917 folder structure skeleton in silabs folder #23750
andy31415
merged 6 commits into
project-chip:master
from
rosahay-silabs:feature/SiWx917_folder_skeleton
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov and
LuDuda
November 24, 2022 16:05
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple and
xylophone21
November 24, 2022 16:05
jmartinez-silabs
approved these changes
Nov 24, 2022
PR #23750: Size comparison from 6026c60 to 467bbec Increases (12 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for bl602, bl702, cc13x2_26x2, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23750: Size comparison from 1a56789 to 7bb31b5 Increases (6 builds for cc13x2_26x2, efr32, k32w, psoc6, telink)
Decreases (8 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
approved these changes
Nov 28, 2022
selissia
approved these changes
Nov 28, 2022
andy31415
approved these changes
Nov 29, 2022
andy31415
reviewed
Nov 21, 2023
|
||
#include <platform/CHIPDeviceLayer.h> | ||
//#include <app/server/Mdns.h> | ||
#include <app/server/Dnssd.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are dependency inversions: platform should not depend on app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of EFR32 folder in SiWx917 folder
!!! no need to review the files, it's just a copy of EFR32 files. Just verifying the path is enough