-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Binding] Improve binding validation and disable connection on init #23749
Merged
andy31415
merged 20 commits into
project-chip:master
from
Grundfos:rjosefsen/update-binding-manager
Jan 19, 2023
Merged
[Binding] Improve binding validation and disable connection on init #23749
andy31415
merged 20 commits into
project-chip:master
from
Grundfos:rjosefsen/update-binding-manager
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda and
mlepage-google
November 24, 2022 14:41
PR #23749: Size comparison from faa7b08 to 644b9ef Increases (27 builds for bl602, cc13x2_26x2, linux, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, cc13x2_26x2, psoc6)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ReneJosefsen
changed the title
[Binding] Ability to notify specific binding and disable connection on init
[Binding] Improve binding validation and disable connection on init
Jan 10, 2023
PR #23749: Size comparison from faa7b08 to e8262ca Increases (30 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for bl702, cc13x2_26x2, cyw30739, efr32, psoc6)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23749: Size comparison from faa7b08 to 43bd36c Increases (30 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 11, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
PR #23749: Size comparison from c5cb0dd to 35abfa9 Increases (24 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for bl702, cc13x2_26x2, linux, psoc6)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23749: Size comparison from e1cb26c to a3761b1 Increases (23 builds for bl702, cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23749: Size comparison from 36133b1 to 3bb0c7c Increases (24 builds for bl602, bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for cc13x2_26x2, cyw30739, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
reviewed
Jan 19, 2023
jmeg-sfy
approved these changes
Jan 19, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…roject-chip#23749) * Ability to notify specific binding and disable connection on init * Aligned param naming * Fixes from restyle * Missing restyle * Changed member name and added documentation * Updated validation in bindings and removed AtIndex function * Added missing include file * Fixed missing emberAfContainsClient by using other available functions * Added check of emberAfFindEndpointType in case it returns nullptr * Reintroduced emberAfContainsClient and reverted bindings to use this * Enabled onOff client on all-clusters-app to fix failing tests * Fixed spelling error and added notify if not list operation * Update src/app/clusters/bindings/bindings.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Try to fix CI failure Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
A function to only notify a specific index in the binding table, this is to allow applications to not initiate connections to all (possible unsupported) bindings.Change overview
Add NotifyBoundClusterAtIndexChanged function (similar to NotifyBoundClusterChanged), which only handles the specific binding set in the bindingIndex parameter.Testing
Tested on a Pump implementation based on CC2652R7
Verified that only a single connection was established when multiple binding (to separate peers) was in the binding tableFixes #24483