Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Add the missing judgement condition of GetPartitionLabelByNamespace #23738

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[ESP32] Add the missing judgement condition of GetPartitionLabelByNamespace #23738

merged 1 commit into from
Nov 30, 2022

Conversation

Jerry-ESP
Copy link
Contributor

In the ESP32Config::GetPartitionLabelByNamespace() function, there is a judgement condition missing when get kConfigNamespace_ChipCounters namespace partition.

In this PR I add this condition.

@github-actions github-actions bot added the esp32 label Nov 23, 2022
@github-actions
Copy link

github-actions bot commented Nov 23, 2022 •
edited
Loading

PR #23738: Size comparison from c90354b to 0b215a1

Increases (6 builds for esp32, nrfconnect, psoc6, telink)
platform target config section c90354b 0b215a1 change % change
esp32 all-clusters-app c3devkit (read only) 1214662 1214666 4 0.0
.flash.text 1214662 1214666 4 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 806932 806936 4 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26758663 26758664 1 0.0
telink light-switch-app tlsr9518adk80d (read/write) 791992 792000 8 0.0
text 555308 555312 4 0.0
lighting-app tlsr9518adk80d text 625624 625626 2 0.0
ota-requestor-app tlsr9518adk80d text 566670 566672 2 0.0
Decreases (10 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, telink)
platform target config section c90354b 0b215a1 change % change
bl602 lighting-app bl602 (read/write) 1377454 1377446 -8 -0.0
.text 1061186 1061184 -2 -0.0
bl702 lighting-app bl702 .debug_info 39167891 39167889 -2 -0.0
.text 957064 957060 -4 -0.0
bl702+rpc .debug_info 43440664 43440663 -1 -0.0
.text 1031044 1031042 -2 -0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 643827 643819 -8 -0.0
.text 564448 564440 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588334 588326 -8 -0.0
.app_xip_area 464544 464536 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544778 544770 -8 -0.0
.app_xip_area 426508 426500 -8 -0.0
esp32 all-clusters-app c3devkit (read/write) 1786670 1786662 -8 -0.0
.flash.rodata 256496 256488 -8 -0.0
m5stack (read/write) 562644 562636 -8 -0.0
.flash.rodata 313616 313608 -8 -0.0
telink all-clusters-app tlsr9518adk80d text 650284 650282 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 614242 614240 -2 -0.0
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
platform target config section c90354b 0b215a1 change % change
bl602 lighting-app bl602 (read/write) 1377454 1377446 -8 -0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1061186 1061184 -2 -0.0
bl602+rpc (read/write) 1423310 1423310 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1092656 1092656 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1196871 1196871 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524270 1524270 0 0.0
.debug_aranges 132424 132424 0 0.0
.debug_frame 485832 485832 0 0.0
.debug_info 39167891 39167889 -2 -0.0
.debug_line 5276251 5276251 0 0.0
.debug_loc 3373401 3373401 0 0.0
.debug_ranges 361248 361248 0 0.0
.debug_str 3474852 3474852 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116680 116680 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568355 568355 0 0.0
.symtab 172048 172048 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957064 957060 -4 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285411 1285411 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1668440 1668440 0 0.0
.debug_aranges 140520 140520 0 0.0
.debug_frame 513168 513168 0 0.0
.debug_info 43440664 43440663 -1 -0.0
.debug_line 5673645 5673645 0 0.0
.debug_loc 3568012 3568012 0 0.0
.debug_ranges 384768 384768 0 0.0
.debug_str 3872449 3872449 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130424 130424 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628505 628505 0 0.0
.symtab 190192 190192 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031044 1031042 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679571 679571 0 0.0
(read/write) 171964 171964 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89923 89923 0 0.0
.text 589336 589336 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643827 643819 -8 -0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79059 79059 0 0.0
.text 564448 564440 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 677183 677183 0 0.0
(read/write) 171920 171920 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77351 77351 0 0.0
.text 599352 599352 0 0.0
lock-mtd LP_CC2652R7 (read only) 661963 661963 0 0.0
(read/write) 182396 182396 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103435 103435 0 0.0
.text 558048 558048 0 0.0
pump-app LP_CC2652R7 (read only) 690055 690055 0 0.0
(read/write) 159784 159784 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90871 90871 0 0.0
.text 598700 598700 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674035 674035 0 0.0
(read/write) 175900 175900 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86427 86427 0 0.0
.text 587128 587128 0 0.0
shell LP_CC2652R7 (read only) 670790 670790 0 0.0
(read/write) 183064 183064 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86670 86670 0 0.0
.text 583804 583804 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588334 588326 -8 -0.0
.app_xip_area 464544 464536 -8 -0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592098 592098 0 0.0
.app_xip_area 463012 463012 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544778 544770 -8 -0.0
.app_xip_area 426508 426500 -8 -0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975972 975972 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 821524 821524 0 0.0
BRD4161A+rs911x (read/write) 1037176 1037176 0 0.0
.bss 186744 186744 0 0.0
.data 2012 2012 0 0.0
.text 848396 848396 0 0.0
BRD4187C (read/write) 1148728 1148728 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 982960 982960 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163264 1163264 0 0.0
.bss 158312 158312 0 0.0
.data 2020 2020 0 0.0
.text 1002908 1002908 0 0.0
window-app BRD4187C (read/write) 1141452 1141452 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 974244 974244 0 0.0
esp32 all-clusters-app c3devkit (read only) 1214662 1214666 4 0.0
(read/write) 1786670 1786662 -8 -0.0
.dram0.bss 76688 76688 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256496 256488 -8 -0.0
.flash.text 1214662 1214666 4 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1225427 1225427 0 0.0
(read/write) 562644 562636 -8 -0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313616 313608 -8 -0.0
.flash.text 1220043 1220043 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662692 662692 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564364 564364 0 0.0
light k32w0+release (read/write) 673224 673224 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 593524 593524 0 0.0
lock k32w0+release (read/write) 634252 634252 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553772 553772 0 0.0
linux all-clusters-app debug (read only) 3083513 3083513 0 0.0
(read/write) 158472 158472 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281195 281195 0 0.0
.text 2617826 2617826 0 0.0
all-clusters-minimal-app debug (read only) 2909161 2909161 0 0.0
(read/write) 149872 149872 0 0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280683 280683 0 0.0
.text 2447026 2447026 0 0.0
bridge-app debug+rpc (read only) 2406417 2406417 0 0.0
(read/write) 129608 129608 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210816 210816 0 0.0
.text 2028242 2028242 0 0.0
chip-tool debug (read only) 11099473 11099473 0 0.0
(read/write) 659616 659616 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 624352 624352 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 592965 592965 0 0.0
.text 8980068 8980068 0 0.0
chip-tool-ipv6only arm64 (read only) 10450060 10450060 0 0.0
(read/write) 707713 707713 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652008 652008 0 0.0
.dynamic 560 560 0 0.0
.got 13944 13944 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 519468 519468 0 0.0
.text 8271988 8271988 0 0.0
lighting-app debug+rpc (read only) 2639185 2639185 0 0.0
(read/write) 132456 132456 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73992 73992 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227808 227808 0 0.0
.text 2234674 2234674 0 0.0
lock-app debug (read only) 2595993 2595993 0 0.0
(read/write) 127376 127376 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244072 244072 0 0.0
.text 2180210 2180210 0 0.0
ota-provider-app debug (read only) 2390321 2390321 0 0.0
(read/write) 120904 120904 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64760 64760 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 216488 216488 0 0.0
.text 2005282 2005282 0 0.0
ota-requestor-app debug (read only) 2557121 2557121 0 0.0
(read/write) 129248 129248 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 223568 223568 0 0.0
.text 2155906 2155906 0 0.0
shell debug (read only) 2619009 2619009 0 0.0
(read/write) 142968 142968 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239442 239442 0 0.0
.text 2220050 2220050 0 0.0
thermostat-no-ble arm64 (read only) 2387012 2387012 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145068 145068 0 0.0
.text 1998048 1998048 0 0.0
tv-app debug (read only) 3253585 3253585 0 0.0
(read/write) 262152 262152 0 0.0
.bss 170808 170808 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268344 268344 0 0.0
.text 2791250 2791250 0 0.0
tv-casting-app debug (read only) 5588489 5588489 0 0.0
(read/write) 162080 162080 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101408 101408 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 355769 355769 0 0.0
.text 4956594 4956594 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453656 2453656 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1416300 1416300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1189583 1189583 0 0.0
bss 145285 145285 0 0.0
rodata 144804 144804 0 0.0
text 818414 818414 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1168963 1168963 0 0.0
bss 144512 144512 0 0.0
rodata 136592 136592 0 0.0
text 806932 806936 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1748228 1748228 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235661 1235661 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 371588 371588 0 0.0
.debug_info 27020983 27020983 0 0.0
.debug_line 3691677 3691677 0 0.0
.debug_loc 3616499 3616499 0 0.0
.debug_ranges 341008 341008 0 0.0
.debug_str 3444213 3444213 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571950 571950 0 0.0
.symtab 421904 421904 0 0.0
.text 1548464 1548464 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690748 1690748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227552 1227552 0 0.0
.debug_aranges 110216 110216 0 0.0
.debug_frame 374668 374668 0 0.0
.debug_info 26758663 26758664 1 0.0
.debug_line 3712661 3712661 0 0.0
.debug_loc 3604105 3604105 0 0.0
.debug_ranges 339624 339624 0 0.0
.debug_str 3433225 3433225 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536039 536039 0 0.0
.symtab 408336 408336 0 0.0
.text 1491720 1491720 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1608924 1608924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062079 1062079 0 0.0
.debug_aranges 102416 102416 0 0.0
.debug_frame 344980 344980 0 0.0
.debug_info 22227199 22227199 0 0.0
.debug_line 3281782 3281782 0 0.0
.debug_loc 3301540 3301540 0 0.0
.debug_ranges 304904 304904 0 0.0
.debug_str 3238811 3238811 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472364 472364 0 0.0
.symtab 376704 376704 0 0.0
.text 1418080 1418080 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642436 1642436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064054 1064054 0 0.0
.debug_aranges 102816 102816 0 0.0
.debug_frame 346832 346832 0 0.0
.debug_info 22446758 22446758 0 0.0
.debug_line 3276610 3276610 0 0.0
.debug_loc 3323117 3323117 0 0.0
.debug_ranges 306288 306288 0 0.0
.debug_str 3255068 3255068 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474151 474151 0 0.0
.symtab 378368 378368 0 0.0
.text 1446600 1446600 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 939068 939068 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 650284 650282 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 877036 877036 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 614242 614240 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 791992 792000 8 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 555308 555312 4 0.0
lighting-app tlsr9518adk80d (read/write) 876576 876576 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 625624 625626 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 806468 806468 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 566670 566672 2 0.0

@Jerry-ESP Jerry-ESP force-pushed the ESP32/fix-issue-of-GetPartitionLabelByNamespace branch from 0b215a1 to beecdea Compare November 24, 2022 11:59
@github-actions
Copy link

github-actions bot commented Nov 24, 2022 •
edited
Loading

PR #23738: Size comparison from 7f1b4b8 to beecdea

Increases (7 builds for cc13x2_26x2, efr32, psoc6, qpg, telink)
platform target config section 7f1b4b8 beecdea change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679547 679555 8 0.0
.text 589312 589320 8 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976084 976100 16 0.0
.text 821636 821652 16 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22239416 22239417 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22458789 22458790 1 0.0
qpg lock-app qpg6105+debug (read/write) 1116820 1116828 8 0.0
.text 563916 563924 8 0.0
telink ota-requestor-app tlsr9518adk80d text 566698 566700 2 0.0
thermostat tlsr9518adk80d (read/write) 793348 793356 8 0.0
text 554332 554334 2 0.0
Decreases (10 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, psoc6, telink)
platform target config section 7f1b4b8 beecdea change % change
bl602 lighting-app bl602+rpc .text 1092604 1092602 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 43466331 43466330 -1 -0.0
.text 1031098 1031096 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 171988 171980 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643811 643803 -8 -0.0
.text 564432 564424 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 562700 562692 -8 -0.0
.flash.rodata 313672 313664 -8 -0.0
k32w contact k32w0+release (read/write) 662612 662596 -16 -0.0
.text 564284 564268 -16 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27036121 27036120 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 614226 614224 -2 -0.0
light-switch-app tlsr9518adk80d text 555362 555360 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 876576 876568 -8 -0.0
text 625614 625612 -2 -0.0
Full report (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 7f1b4b8 beecdea change % change
bl602 lighting-app bl602 (read/write) 1377590 1377590 0 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1061268 1061268 0 0.0
bl602+rpc (read/write) 1423270 1423270 0 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1092604 1092602 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1197127 1197127 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524298 1524298 0 0.0
.debug_aranges 132440 132440 0 0.0
.debug_frame 485880 485880 0 0.0
.debug_info 39168501 39168501 0 0.0
.debug_line 5276293 5276293 0 0.0
.debug_loc 3373589 3373589 0 0.0
.debug_ranges 361264 361264 0 0.0
.debug_str 3475236 3475236 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568438 568438 0 0.0
.symtab 172080 172080 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957258 957258 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285475 1285475 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1671401 1671401 0 0.0
.debug_aranges 140576 140576 0 0.0
.debug_frame 513304 513304 0 0.0
.debug_info 43466331 43466330 -1 -0.0
.debug_line 5695024 5695024 0 0.0
.debug_loc 3568815 3568815 0 0.0
.debug_ranges 384752 384752 0 0.0
.debug_str 3874745 3874745 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130440 130440 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628592 628592 0 0.0
.symtab 190224 190224 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031098 1031096 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679547 679555 8 0.0
(read/write) 171988 171980 -8 -0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89923 89923 0 0.0
.text 589312 589320 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643811 643803 -8 -0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79059 79059 0 0.0
.text 564432 564424 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 677087 677087 0 0.0
(read/write) 172016 172016 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77351 77351 0 0.0
.text 599256 599256 0 0.0
lock-mtd LP_CC2652R7 (read only) 661875 661875 0 0.0
(read/write) 182484 182484 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103435 103435 0 0.0
.text 557960 557960 0 0.0
pump-app LP_CC2652R7 (read only) 690095 690095 0 0.0
(read/write) 159744 159744 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90927 90927 0 0.0
.text 598684 598684 0 0.0
pump-controller-app LP_CC2652R7 (read only) 673931 673931 0 0.0
(read/write) 176004 176004 0 0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86427 86427 0 0.0
.text 587024 587024 0 0.0
shell LP_CC2652R7 (read only) 670766 670766 0 0.0
(read/write) 183088 183088 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86670 86670 0 0.0
.text 583780 583780 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588446 588446 0 0.0
.app_xip_area 464696 464696 0 0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592146 592146 0 0.0
.app_xip_area 463100 463100 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544826 544826 0 0.0
.app_xip_area 426588 426588 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976084 976100 16 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 821636 821652 16 0.0
BRD4161A+rs911x (read/write) 1037648 1037648 0 0.0
.bss 186744 186744 0 0.0
.data 2012 2012 0 0.0
.text 848872 848872 0 0.0
BRD4187C (read/write) 1149140 1149140 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 983372 983372 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163264 1163264 0 0.0
.bss 158312 158312 0 0.0
.data 2020 2020 0 0.0
.text 1002912 1002912 0 0.0
window-app BRD4187C (read/write) 1141728 1141728 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 974520 974520 0 0.0
esp32 all-clusters-app c3devkit (read only) 1214742 1214742 0 0.0
(read/write) 1786726 1786726 0 0.0
.dram0.bss 76688 76688 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256552 256552 0 0.0
.flash.text 1214742 1214742 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1225499 1225499 0 0.0
(read/write) 562700 562692 -8 -0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313672 313664 -8 -0.0
.flash.text 1220115 1220115 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662612 662596 -16 -0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564284 564268 -16 -0.0
light k32w0+release (read/write) 673264 673264 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 593564 593564 0 0.0
lock k32w0+release (read/write) 634140 634140 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553660 553660 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10450060 10450060 0 0.0
(read/write) 707713 707713 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652008 652008 0 0.0
.dynamic 560 560 0 0.0
.got 13944 13944 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 519468 519468 0 0.0
.text 8271988 8271988 0 0.0
thermostat-no-ble arm64 (read only) 2387012 2387012 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145068 145068 0 0.0
.text 1998048 1998048 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453760 2453760 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1416404 1416404 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1189799 1189799 0 0.0
bss 145285 145285 0 0.0
rodata 144860 144860 0 0.0
text 818580 818580 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1169195 1169195 0 0.0
bss 144512 144512 0 0.0
rodata 136648 136648 0 0.0
text 807102 807102 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1748508 1748508 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235829 1235829 0 0.0
.debug_aranges 110752 110752 0 0.0
.debug_frame 371636 371636 0 0.0
.debug_info 27036121 27036120 -1 -0.0
.debug_line 3691216 3691216 0 0.0
.debug_loc 3616230 3616230 0 0.0
.debug_ranges 340824 340824 0 0.0
.debug_str 3444720 3444720 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571529 571529 0 0.0
.symtab 422000 422000 0 0.0
.text 1548744 1548744 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1691028 1691028 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227720 1227720 0 0.0
.debug_aranges 110224 110224 0 0.0
.debug_frame 374692 374692 0 0.0
.debug_info 26773623 26773623 0 0.0
.debug_line 3712196 3712196 0 0.0
.debug_loc 3603836 3603836 0 0.0
.debug_ranges 339440 339440 0 0.0
.debug_str 3433732 3433732 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535618 535618 0 0.0
.symtab 408432 408432 0 0.0
.text 1492000 1492000 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1609228 1609228 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062243 1062243 0 0.0
.debug_aranges 102424 102424 0 0.0
.debug_frame 345028 345028 0 0.0
.debug_info 22239416 22239417 1 0.0
.debug_line 3281548 3281548 0 0.0
.debug_loc 3301679 3301679 0 0.0
.debug_ranges 304704 304704 0 0.0
.debug_str 3239318 3239318 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471943 471943 0 0.0
.symtab 376800 376800 0 0.0
.text 1418384 1418384 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642580 1642580 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064234 1064234 0 0.0
.debug_aranges 102816 102816 0 0.0
.debug_frame 346848 346848 0 0.0
.debug_info 22458789 22458790 1 0.0
.debug_line 3276274 3276274 0 0.0
.debug_loc 3323053 3323053 0 0.0
.debug_ranges 306080 306080 0 0.0
.debug_str 3255210 3255210 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473659 473659 0 0.0
.symtab 378416 378416 0 0.0
.text 1446744 1446744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151028 1151028 0 0.0
.bss 97628 97628 0 0.0
.data 840 840 0 0.0
.text 598128 598128 0 0.0
lock-app qpg6105+debug (read/write) 1116820 1116828 8 0.0
.bss 93100 93100 0 0.0
.data 836 836 0 0.0
.text 563916 563924 8 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 939068 939068 0 0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 650270 650270 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 877028 877028 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 614226 614224 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 792184 792184 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 555362 555360 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 876576 876568 -8 -0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 625614 625612 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 806552 806552 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 566698 566700 2 0.0
thermostat tlsr9518adk80d (read/write) 793348 793356 8 0.0
bss 73852 73852 0 0.0
noinit 43480 43480 0 0.0
text 554332 554334 2 0.0

@bzbarsky-apple bzbarsky-apple merged commit 23aafa6 into project-chip:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@wqx6 wqx6 wqx6 approved these changes

@dhrishi dhrishi dhrishi approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
esp32 platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jerry-ESP @dhrishi @wqx6 @bzbarsky-apple