Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Fixed factory data generation bug #23737

Merged
merged 1 commit into from
Nov 23, 2022
Merged

[nrfconnect] Fixed factory data generation bug #23737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions docs/guides/nrfconnect_factory_data_configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,9 @@ $ python scripts/tools/nrfconnect/generate_nrfconnect_chip_factory_data.py -h
- Automatic:

```
--passcode <pass_code> --spake2p_path <path to spake2p executable>
--passcode <pass_code>
```

> Note: To generate new SPAKE2+ verifier you need `spake2p` executable. See
> the note at the end of this section to learn how to get it.

- Manual:

```
Expand Down Expand Up @@ -320,7 +317,6 @@ $ python scripts/tools/nrfconnect/generate_nrfconnect_chip_factory_data.py \
--discriminator 0xF00 \
--generate_rd_uid \
--passcode 20202021 \
--spake2p_path "src/tools/spake2p/out/spake2p" \
--out "build.json" \
--schema "scripts/tools/nrfconnect/nrfconnect_factory_data.schema"
```
Expand All @@ -333,16 +329,6 @@ If the script finishes successfully, go to the location you provided with the
`-o` argument. Use the JSON file you find there when
[generating the factory data partition](#generating_factory_data_partition).

> Note: Generating the SPAKE2+ verifier is optional and requires providing a
> path to the `spake2p` executable. To get it, complete the following steps:
>
> 1. Navigate to the `connectedhomeip` root directory.
> 2. In a terminal, run the command:
> `cd src/tools/spake2p && gn gen out && ninja -C out spake2p` to build the
> executable.
> 3. Add the `connectedhomeip/src/tools/spake2p/out/spake2p` path as an
> argument of `--spake2p_path` for the Python script.

> Note: Generating new certificates is optional if default vendor and product
> IDs are used and requires providing a path to the `chip-cert` executable. To
> get it, complete the following steps:
Expand Down
2 changes: 1 addition & 1 deletion scripts/tools/nrfconnect/generate_nrfconnect_chip_factory_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ def generate_json(self):
if self._args.enable_key:
self._add_entry("enable_key", HEX_PREFIX + self._args.enable_key)
if self._args.user:
self._add_entry("user", self._args.user)
self._add_entry("user", self._user_data)

factory_data_dict = dict(self._factory_data)

Expand Down