-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Add Service Type Protocol setting in dnssd #23711
Merged
andy31415
merged 8 commits into
project-chip:master
from
joonhaengHeo:fix_wrong_dnssd_service_type
Nov 29, 2022
Merged
[Android] Add Service Type Protocol setting in dnssd #23711
andy31415
merged 8 commits into
project-chip:master
from
joonhaengHeo:fix_wrong_dnssd_service_type
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23711: Size comparison from 669cd47 to 079542d Increases (10 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Decreases (6 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 22, 2022
andy31415
reviewed
Nov 22, 2022
PR #23711: Size comparison from ba8cb33 to 844928c Increases (2 builds for cyw30739, efr32)
Decreases (4 builds for esp32, psoc6)
Full report (19 builds for cyw30739, efr32, esp32, k32w, psoc6, qpg)
|
PR #23711: Size comparison from ba8cb33 to 4836cd9 Increases (8 builds for cc13x2_26x2, cyw30739, efr32, esp32, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (47 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 23, 2022
andy31415
reviewed
Nov 24, 2022
andy31415
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23605.
Added Service Type Protocol setting in DNSSD because it was missing in Android Platform.
-> Add Service Type and Protocol setting.