-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set pw_command_launcher from build_example.py CLI #23702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow effortless ccache setup like this: ./scripts/build/build_examples.py \ --target linux-x64-light \ --pw-command-launcher=ccache \ build
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
November 21, 2022 13:56
pullapprove
bot
requested review from
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 21, 2022 13:56
PR #23702: Size comparison from 494f5f5 to 85bf093 Increases (7 builds for bl602, bl702, cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 21, 2022
PR #23702: Size comparison from 494f5f5 to 246739d Increases (12 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect, telink)
Decreases (17 builds for bl702, cc13x2_26x2, k32w, qpg, telink)
Full report (31 builds for bl602, bl702, cc13x2_26x2, efr32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
andy31415
approved these changes
Nov 21, 2022
Damian-Nordic
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a
pw_command_launcher
option in Pigweed which can be used to setup ccache (or something else). However, it's hard to learn about such option - it's not mentioned in matter repo anywhere.Changes
Add
--pw-command-launcher
option tobuild_examples.py
script (it will be visible in help text)Testing
Tested manually with
ccache
(build time reduced significantly):