-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nRF Connect] Use hardware-accelerated crypto functions #2370
[nRF Connect] Use hardware-accelerated crypto functions #2370
Conversation
Use mbedTLS from nrf_security library which provides hardware-accelerated cryptographic functions.
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "gn_efr32-example-build"
Full report output
|
@@ -74,7 +74,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
|
|||
container: | |||
image: connectedhomeip/chip-build-nrf-platform:0.4.1 | |||
image: connectedhomeip/chip-build-nrf-platform:0.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this image pushed yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and no :)
Initially I asked Andrei to rebuild nrf image with "--no-cache" flag so that fresh sources are picked up. Later we agreed that a cleaner approach would be using specific commit-ids in Dockerfile and not having to bypass the docker cache, so I updated the definition as you have seen. The 0.4.2 image which is on dockerhub right now is the one built with "--no-cache", so it's not the final version yet, but is good enough to build this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to merge them ... I originally needed 0.4.2 to have a JDK in the android-build, so I built one and Damian noticed that the nRF build was odd. We probably want both the nRF build updates and JDK commits in before we create another 'real/final 0.4.3'.
That being said, I have no plans to push any other 0.4.2 until then so this should be safe.
Problem
nRF Connect lock-app uses Zephyr's built-in mbedtls which doesn't include hardware-accelerated cryptographic functions.
Summary of Changes
Configure the example to use nrf_security library which provides implementation optimized for Nordic platforms.
fixes #2369