-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue of unreleased JNI references. #23655
Conversation
PR #23655: Size comparison from cf45410 to 302a5c0 Increases (8 builds for bl702, psoc6, telink)
Decreases (2 builds for esp32, psoc6)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we may want to eventually have a RAII class that handles java UTF Chars. Looking at existing code, I am not conviged we call ReleaseStringUTFChars at all. I will create a new issue for this.
8ab759a
to
797f497
Compare
PR #23655: Size comparison from 4cb51b4 to 797f497 Increases (6 builds for bl602, bl702, psoc6, telink)
Decreases (6 builds for esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Fix the issue of unreleased JNI references. * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Fixes #23648
There were unreleased JNI references that caused the reference table to overflow and caused the crash of the application. Fixed to release/delete references.