-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BdxOtaSender to only cease polling upon successful transfer of the bulk data #23642
Merged
carol-apple
merged 1 commit into
project-chip:master
from
harsha-rajendran:Fix-BdxOtaSender-polling-state
Nov 17, 2022
Merged
Update BdxOtaSender to only cease polling upon successful transfer of the bulk data #23642
carol-apple
merged 1 commit into
project-chip:master
from
harsha-rajendran:Fix-BdxOtaSender-polling-state
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
November 16, 2022 19:45
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
November 16, 2022 19:45
PR #23642: Size comparison from bbf3111 to 954986a Increases (5 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
carol-apple
approved these changes
Nov 16, 2022
selissia
approved these changes
Nov 17, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23573
The BdxOtaSender should ensure that the TransferFacilitator stops polling the TransferSession ONLY upon successfully finishing the Bulk data transfer. In all other cases (error, timeout, etc.), the OTAProvider needs to be able to facilitate delivery of the OTA image.
Tested using the following strategies on Linux OS: